8320597: RSA signature verification fails on signed data that does not encode params correctly

[alexeybakhtin]

Almost clean backport from JDK17 PR
The only difference is a string concatenation in the test

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8320597 needs maintainer approval

Issue

• JDK-8320597: RSA signature verification fails on signed data that does not encode params correctly (Bug - P3 - Approved)

Reviewers

• Martin Balao (@martinuy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2384/head:pull/2384
$ git checkout pull/2384

Update a local copy of the PR:
$ git checkout pull/2384
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2384

View PR using the GUI difftool:
$ git pr show -t 2384

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2384.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into pr/2383 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full - Incremental (29b578c2)
• 02: Full - Incremental (eb933bd5)
• 01: Full - Incremental (c849a466)
• 00: Full (c849a466)

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8320597
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[jerboaa]

@alexeybakhtin Please update the patch. It currently shows changes from #2383 as well.

[martinuy]

Thanks @alexeybakhtin for proposing this backport. The commit specific to 8317547 looks good to me. I'll approve after the rebase.

The Skara bot does not like it but in my view a rebase is cleaner than a merge:

git switch JDK-8320597
git fetch upstream master
git rebase upstream/master
git push --force-with-lease

[alexeybakhtin]

@alexeybakhtin Please update the patch. It currently shows changes from #2383 as well.

Thank you. I've fixed the conflicts

[alexeybakhtin]

Reverted copyright date in RSAPadding.java Looks like a merge issue

[martinuy]

Looks good to me. Thanks.-

[openjdk]

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8320597: RSA signature verification fails on signed data that does not encode params correctly

Reviewed-by: mbalao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexeybakhtin]

/integrate

[openjdk]

Going to push as commit 4470c0a.

[openjdk]

@alexeybakhtin Pushed as commit 4470c0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.