8272551: mark hotspot runtime/modules tests which ignore external VM flags

[amosshi]

Backport of JDK-8272551

Unclean Backport:

• test/hotspot/jtreg/runtime/modules/ModuleOptionsTest.java
• test/hotspot/jtreg/runtime/modules/ModuleOptionsWarn.java
• test/hotspot/jtreg/runtime/modules/ModuleStress/ExportModuleStressTest.java
• test/hotspot/jtreg/runtime/modules/PatchModule/PatchModuleDupJavaBase.java
• test/hotspot/jtreg/runtime/modules/PatchModule/PatchModuleDupModule.java
  • All the differences of the files above are the Copyright year line. Manually merged.
  • These files can be considered as Clean backport
• test/hotspot/jtreg/runtime/modules/ModulesSymLink.java
  • This file is ingnored because it does not exit in Java 11
  • This file was added via JDK-8220095 since Java 13

Tests

• Test Succeeded in local Dev Apple M1 Laptop
• PR: All checks have passed
• SAP nightlies passed on 2023-12-23,24

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8272551 needs maintainer approval

Issue

• JDK-8272551: mark hotspot runtime/modules tests which ignore external VM flags (Sub-task - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2389/head:pull/2389
$ git checkout pull/2389

Update a local copy of the PR:
$ git checkout pull/2389
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2389/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2389

View PR using the GUI difftool:
$ git pr show -t 2389

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2389.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (3276c6cd)

[amosshi]

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Unclean backport. SAP nightlies passed on 2023-12-19”

[openjdk]

@amosshi
8272551: The approval request has been created successfully.

[TheRealMDoerr]

Maybe the test from JDK-8220095 will get backported later which will require the addition. But that's trivial. LTGM.

[openjdk]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[amosshi]

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Unclean backport. SAP nightlies passed on 2023-12-23”

[openjdk]

@amosshi
8272551: The approval request has been updated successfully.

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272551: mark hotspot runtime/modules tests which ignore external VM flags

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

• b714f1e: 8208278: [mlvm] [TESTBUG] vm.mlvm.mixed.stress.java.findDeadlock.INDIFY_Test Deadlocked threads are not always detected
• b90b1d2: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
• 73e40c9: 8317327: Remove JT_JAVA dead code in jib-profiles.js
• 6a5a8ee: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee
• 1583c4e: 8308223: failure handler missed jcmd.vm.info command
• 5571faf: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"
• 9cff0d4: 8302109: Trivial fixes to btree tests
• 92534aa: 8289948: Improve test coverage for XPath functions: Node Set Functions
• 53824e5: 8313816: Accessing jmethodID might lead to spurious crashes
• b6e6d38: 8067651: LevelTransitionTest.java, fix trivial methods levels logic
• ... and 63 more: https://git.openjdk.org/jdk11u-dev/compare/e793bdd174ad976f567d0d911db42f67f6d7e59d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[amosshi]

/integrate

[openjdk]

@amosshi
Your change (at version 3276c6c) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit 98cbef8.
Since your change was applied there have been 75 commits pushed to the master branch:

• d7eeb39: 8272291: mark hotspot runtime/logging tests which ignore external VM flags
• b8e0b56: 8226910: make it possible to use jtreg's -match via run-test framework
• b714f1e: 8208278: [mlvm] [TESTBUG] vm.mlvm.mixed.stress.java.findDeadlock.INDIFY_Test Deadlocked threads are not always detected
• b90b1d2: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
• 73e40c9: 8317327: Remove JT_JAVA dead code in jib-profiles.js
• 6a5a8ee: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee
• 1583c4e: 8308223: failure handler missed jcmd.vm.info command
• 5571faf: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"
• 9cff0d4: 8302109: Trivial fixes to btree tests
• 92534aa: 8289948: Improve test coverage for XPath functions: Node Set Functions
• ... and 65 more: https://git.openjdk.org/jdk11u-dev/compare/e793bdd174ad976f567d0d911db42f67f6d7e59d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @amosshi Pushed as commit 98cbef8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.