-
Notifications
You must be signed in to change notification settings - Fork 238
8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM #2391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ashi! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Hi @amosshi, if you base this on the 17u backport it is probably clean. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a clean backport from 17u.
This backport pull request has now been updated with issue from the original commit. |
|
This backport pull request has now been updated with issue from the original commit. |
/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Clean backport. SAP nightlies passed on 2023-12-19” |
@GoeLin Changed to the the 17 commit 728dc4de173f2bb1e06b3b3574cb430621e2969b |
@amosshi This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 104 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit f6ddc4b.
Your commit was automatically rebased without conflicts. |
Backport of JDK-8296083
About Clean vs Unclean
jdk
:test/jdk/ProblemList.txt
The change to this file has been ignored, because thebug6263446.java
line does not existjdk17u-dev
Tests
2023-12-19
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2391/head:pull/2391
$ git checkout pull/2391
Update a local copy of the PR:
$ git checkout pull/2391
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2391/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2391
View PR using the GUI difftool:
$ git pr show -t 2391
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2391.diff
Webrev
Link to Webrev Comment