Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating #2394

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Dec 15, 2023

Backport of JDK-8308043

Unclean Backport:

  • test/hotspot/jtreg/ProblemList-Xcomp.txt
    • The changes of this file has been ignored, because the line TestCSLocker.java does not exist

Tests

  • Test Succeeded in local Dev Apple M1 Laptop
  • PR: All checks have passed
  • SAP nightlies passed on 2023-12-21,22,23,24

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8308043 needs maintainer approval

Issue

  • JDK-8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2394/head:pull/2394
$ git checkout pull/2394

Update a local copy of the PR:
$ git checkout pull/2394
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2394

View PR using the GUI difftool:
$ git pr show -t 2394

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2394.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 285c833ffacdaabe7c4955cbbafb3bc459d26784 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 15, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Dec 15, 2023

Hi @amosshi, if you base this on the 17u backport it is probably clean.

@amosshi amosshi changed the title 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating Backport 3c43d762cc9bcffede8639479a64c3051cfbcf72 Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

⚠️ @amosshi could not find any commit with hash 3c43d762cc9bcffede8639479a64c3051cfbcf72. Please update the title with the hash for an existing commit.

@amosshi amosshi changed the title Backport 3c43d762cc9bcffede8639479a64c3051cfbcf72 Backport 285c833ffacdaabe7c4955cbbafb3bc459d26784 Dec 17, 2023
@amosshi amosshi changed the title Backport 285c833ffacdaabe7c4955cbbafb3bc459d26784 Backport 6a9a5efe74f59a0f508f6f748c3b062178dccd0b Dec 17, 2023
@openjdk openjdk bot changed the title Backport 6a9a5efe74f59a0f508f6f748c3b062178dccd0b 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating Dec 17, 2023
@openjdk
Copy link

openjdk bot commented Dec 17, 2023

This backport pull request has now been updated with issue from the original commit.

@amosshi
Copy link
Contributor Author

amosshi commented Dec 22, 2023

/approval request “Backporting for parity with jdk 11.0.23-oracle. No risk, test fix. UnClean backport. SAP nightlies passed on 2023-12-24”

@openjdk
Copy link

openjdk bot commented Dec 22, 2023

@amosshi
8308043: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Dec 22, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 28, 2023

Hi @amosshi, if you base this on the 17u backport it is probably clean.

@GoeLin It has been change to 17 commit: 6a9a5efe74f59a0f508f6f748c3b062178dccd0b

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could have backported this clean from 17u-dev.

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

  • a6fc00a: 8269025: jsig/Testjsig.java doesn't check exit code
  • 43d4c50: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
  • 823b65a: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 234d2f0: 8316028: Update FreeType to 2.13.2
  • b31ee7f: 8253820: Save test images and dumps with timestamps from client sanity suite
  • f308f3e: 8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing
  • d232723: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • 879f7cf: 8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"
  • 483bbff: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"
  • 6201dcc: 8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails
  • ... and 76 more: https://git.openjdk.org/jdk11u-dev/compare/e793bdd174ad976f567d0d911db42f67f6d7e59d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 29, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 29, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 29, 2023
@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@amosshi
Your change (at version e4b9992) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Dec 29, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

Going to push as commit 96057c1.
Since your change was applied there have been 86 commits pushed to the master branch:

  • a6fc00a: 8269025: jsig/Testjsig.java doesn't check exit code
  • 43d4c50: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
  • 823b65a: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 234d2f0: 8316028: Update FreeType to 2.13.2
  • b31ee7f: 8253820: Save test images and dumps with timestamps from client sanity suite
  • f308f3e: 8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing
  • d232723: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • 879f7cf: 8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"
  • 483bbff: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"
  • 6201dcc: 8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails
  • ... and 76 more: https://git.openjdk.org/jdk11u-dev/compare/e793bdd174ad976f567d0d911db42f67f6d7e59d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2023
@openjdk openjdk bot closed this Dec 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 29, 2023
@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@GoeLin @amosshi Pushed as commit 96057c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8308043 branch December 30, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants