Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files #2395

Closed
wants to merge 3 commits into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Dec 15, 2023

Backport of JDK-8308116

Unclean Backport:

  • test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler.java
    • The Copyright year line is conflicting; merged manually.
    • This file can be considered as Clean
  • Added the dependency change on this file in JDK-8278028: commit 03f647f or else there are mass compile error

Tests

  • PR: All checks have passed
  • SAP nightlies passed on 2023-Dec-27

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8308116 needs maintainer approval

Issue

  • JDK-8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2395/head:pull/2395
$ git checkout pull/2395

Update a local copy of the PR:
$ git checkout pull/2395
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2395

View PR using the GUI difftool:
$ git pr show -t 2395

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2395.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e9320f31dcc4ff5197e8c3bca504a7d5c1a9035e 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2023

Webrevs

@openjdk openjdk bot removed the clean label Dec 19, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 29, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. UnClean backport. No risk, test fix. SAP nightlies passed on 2023-12-27”

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@amosshi
8308116: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 29, 2023
@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • e55ee09: 8322752: [11u] GetStackTraceAndRetransformTest.java is failing assert
  • 96057c1: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • a6fc00a: 8269025: jsig/Testjsig.java doesn't check exit code
  • 43d4c50: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
  • 823b65a: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 234d2f0: 8316028: Update FreeType to 2.13.2
  • b31ee7f: 8253820: Save test images and dumps with timestamps from client sanity suite
  • f308f3e: 8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing
  • d232723: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • 879f7cf: 8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"
  • ... and 25 more: https://git.openjdk.org/jdk11u-dev/compare/4470c0a7be58ffa9b3c2e80f52b8795300a349b5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 29, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 30, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 30, 2023
@openjdk
Copy link

openjdk bot commented Dec 30, 2023

@amosshi
Your change (at version 1f82b3d) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Dec 30, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 30, 2023

Going to push as commit 2da1ac7.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 4f91f8f: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
  • d94b3f8: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • e55ee09: 8322752: [11u] GetStackTraceAndRetransformTest.java is failing assert
  • 96057c1: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • a6fc00a: 8269025: jsig/Testjsig.java doesn't check exit code
  • 43d4c50: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
  • 823b65a: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 234d2f0: 8316028: Update FreeType to 2.13.2
  • b31ee7f: 8253820: Save test images and dumps with timestamps from client sanity suite
  • f308f3e: 8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing
  • ... and 27 more: https://git.openjdk.org/jdk11u-dev/compare/4470c0a7be58ffa9b3c2e80f52b8795300a349b5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 30, 2023
@openjdk openjdk bot closed this Dec 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 30, 2023
@openjdk
Copy link

openjdk bot commented Dec 30, 2023

@GoeLin @amosshi Pushed as commit 2da1ac7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8308116 branch December 30, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants