Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller #24

Closed
wants to merge 1 commit into from

Conversation

@dchuyko
Copy link
Member

@dchuyko dchuyko commented Jun 10, 2021

This small patch reduces registers spilling on aarch64. Changes bring the save policy in line with AArch64 ABI.

Original patch require simple adjustments to the context.

Testing: tier1, tier2, opto assembly check.

11u RFR: https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-May/006239.html
https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-May/006373.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/24.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 10, 2021

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@dchuyko dchuyko changed the title [PATCH] Backport ba174af3446b667a342947a259b45a09ff135a05 Backport ba174af3446b667a342947a259b45a09ff135a05 Jun 10, 2021
@openjdk openjdk bot changed the title Backport ba174af3446b667a342947a259b45a09ff135a05 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2021

Webrevs

Loading

adinn
adinn approved these changes Jun 11, 2021
Copy link
Contributor

@adinn adinn left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@dchuyko This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller

Reviewed-by: adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@adinn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Jun 11, 2021
@adinn
Copy link
Contributor

@adinn adinn commented Jun 11, 2021

Dmitry please integrate and I will sponsor

Loading

@dchuyko
Copy link
Member Author

@dchuyko dchuyko commented Jun 11, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Jun 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@dchuyko
Your change (at version 3e43652) is now ready to be sponsored by a Committer.

Loading

@adinn
Copy link
Contributor

@adinn adinn commented Jun 11, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

Going to push as commit d31ceee.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@adinn @dchuyko Pushed as commit d31ceee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants