Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320798: Console read line with zero out should zero out underlying buffer #2400

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 16, 2023

A fix we should have in 11., backported from 17.
Basically the same change, but I had to adapt the instanceof statements to syntax of 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320798 needs maintainer approval

Issue

  • JDK-8320798: Console read line with zero out should zero out underlying buffer (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2400/head:pull/2400
$ git checkout pull/2400

Update a local copy of the PR:
$ git checkout pull/2400
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2400/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2400

View PR using the GUI difftool:
$ git pr show -t 2400

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2400.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 48c847836e44aec2d5be4aaa3040dffc9d95fad5 8320798: Console read line with zero out should zero out underlying buffer Dec 16, 2023
@openjdk
Copy link

openjdk bot commented Dec 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 16, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for backporting!

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8320798: Console read line with zero out should zero out underlying buffer

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • dc374f6: 8322178: Error. can't find jdk.testlibrary.SimpleSSLContext in test directory or libraries

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 18, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 18, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

Going to push as commit 93f7a8c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • dc374f6: 8322178: Error. can't find jdk.testlibrary.SimpleSSLContext in test directory or libraries

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 18, 2023
@openjdk openjdk bot closed this Dec 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@GoeLin Pushed as commit 93f7a8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8320798 branch December 18, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants