8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux

[jerboaa]

Please review this backport of JDK-8255790 which fixes a crash of simple FileDialog-using apps on some systems (for example F34 when not using system harfbuzz). See JDK-8272149. In a nutshell, this patch is a not quite complete revert of JDK-8249821. I.e. the OpenJDK 11u version of it. It does not revert the source code re-structuring, though. The JDK 17 patch doesn't apply clean. I've mostly hand-picked changes from the original patch. Note that JDK-8272332 is included in this backport. The differences mostly stem from differences in DISABLED_WARNINGS_ settings when BUILD_FONTMANAGER is being called.

Testing: Build on an affected system with/without --with-harfbuzz=system. Reproducer from JDK-8272149 (crashes before, passes after)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issues

• JDK-8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
• JDK-8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/241/head:pull/241
$ git checkout pull/241

Update a local copy of the PR:
$ git checkout pull/241
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/241/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 241

View PR using the GUI difftool:
$ git pr show -t 241

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/241.diff

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[jerboaa]

/issue add JDK-8272332

[mlbridge]

Webrevs

• 00: Full (423e04e0)

[openjdk]

@jerboaa
Adding additional issue to issue list: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790.

[RealCLanger]

At eyeballing this looks good to me. If you can wait, I'd like to run it through SAP's testing tonight and let you know the results tomorrow.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• ba097ca: 8251549: Update docs on building for Git
• 3a88ae7: Merge
• 3a32efc: Merge
• fdbaa23: Merge
• f4772b5: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
• 90d5293: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
• 8f402b2: 8272628: Problemlist gc/stress/gcbasher/TestGCBasherWithCMS.java for x86_32
• 0621d9d: 8226602: Test convenience reactive primitives from java.net.http with RS TCK
• 6722cee: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java
• 5ce46d9: 8248403: AArch64: Remove uses of kernel integer types
• ... and 37 more: https://git.openjdk.java.net/jdk11u-dev/compare/5f9429b58f68a2d71b3dae96e15353b780c745a3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

At eyeballing this looks good to me. If you can wait, I'd like to run it through SAP's testing tonight and let you know the results tomorrow.

Sure, I'll wait. Thanks for the extra tests.

[RealCLanger]

At eyeballing this looks good to me. If you can wait, I'd like to run it through SAP's testing tonight and let you know the results tomorrow.

Sure, I'll wait. Thanks for the extra tests.

Our testing did not reveal issues, so good to go from my end.

[jerboaa]

/integrate

[openjdk]

Going to push as commit 6a6e00e.
Since your change was applied there have been 57 commits pushed to the master branch:

• 83d916e: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u
• 417b388: 8272472: StackGuardPages test doesn't build with glibc 2.34
• a27ee49: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
• 4a2cd36: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
• 519894a: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
• 2d6c976: 8225790: Two NestedDialogs tests fail on Ubuntu
• 7b72611: 8213007: Update the link in test/jdk/sun/security/provider/SecureRandom/DrbgCavp.java
• bf01efa: 8248414: AArch64: Remove uses of long and unsigned long ints
• dfb67bc: 8248682: AArch64: Use ATTRIBUTE_ALIGNED helper
• c81c8e8: 8248671: AArch64: Remove unused variables
• ... and 47 more: https://git.openjdk.java.net/jdk11u-dev/compare/5f9429b58f68a2d71b3dae96e15353b780c745a3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit 6a6e00e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.