Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code #2418

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Dec 26, 2023

I backport this for parity with 11.0.23-oracle.
test/hotspot/jtreg/runtime/duplAttributes/DuplAttributesTest.java
Copyright.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8271094 needs maintainer approval

Issue

  • JDK-8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2418/head:pull/2418
$ git checkout pull/2418

Update a local copy of the PR:
$ git checkout pull/2418
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2418

View PR using the GUI difftool:
$ git pr show -t 2418

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2418.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 26, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4812e537919dc1b1c08a2a8ddc0c9cb1c69a7744 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code Dec 26, 2023
@openjdk
Copy link

openjdk bot commented Dec 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 26, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 26, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 26, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 27, 2023
@openjdk
Copy link

openjdk bot commented Dec 28, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f308f3e: 8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing
  • d232723: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 28, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

Going to push as commit 43d4c50.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 823b65a: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 234d2f0: 8316028: Update FreeType to 2.13.2
  • b31ee7f: 8253820: Save test images and dumps with timestamps from client sanity suite
  • f308f3e: 8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing
  • d232723: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2023
@openjdk openjdk bot closed this Dec 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2023
@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@luchenlin Pushed as commit 43d4c50.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant