Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264135: UnsafeGetStableArrayElement should account for different JIT implementation details #2420

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Dec 27, 2023

I backport this for parity with 11.0.23-oracle.

“ClassFileInstaller” path is modified as can't find jdk.test.lib.helpers.ClassFileInstaller, then local test pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8264135 needs maintainer approval

Issue

  • JDK-8264135: UnsafeGetStableArrayElement should account for different JIT implementation details (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2420/head:pull/2420
$ git checkout pull/2420

Update a local copy of the PR:
$ git checkout pull/2420
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2420/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2420

View PR using the GUI difftool:
$ git pr show -t 2420

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2420.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5a930c42de276a31de94d72917425374e3bfe207 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details Dec 27, 2023
@openjdk
Copy link

openjdk bot commented Dec 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 27, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Jan 1, 2024
@openjdk
Copy link

openjdk bot commented Jan 1, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264135: UnsafeGetStableArrayElement should account for different JIT implementation details

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 2da1ac7: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
  • 4f91f8f: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
  • d94b3f8: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • e55ee09: 8322752: [11u] GetStackTraceAndRetransformTest.java is failing assert
  • 96057c1: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • a6fc00a: 8269025: jsig/Testjsig.java doesn't check exit code
  • 43d4c50: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
  • 823b65a: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 234d2f0: 8316028: Update FreeType to 2.13.2
  • b31ee7f: 8253820: Save test images and dumps with timestamps from client sanity suite
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/879f7cf81494e45aeadaf1c67fc039834779012e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 1, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

Going to push as commit 325fc37.
Since your change was applied there have been 14 commits pushed to the master branch:

  • a0fe96e: 8166275: vm/mlvm/meth/stress/compiler/deoptimize keeps timeouting
  • c241718: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 2da1ac7: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
  • 4f91f8f: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
  • d94b3f8: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • e55ee09: 8322752: [11u] GetStackTraceAndRetransformTest.java is failing assert
  • 96057c1: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • a6fc00a: 8269025: jsig/Testjsig.java doesn't check exit code
  • 43d4c50: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
  • 823b65a: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/879f7cf81494e45aeadaf1c67fc039834779012e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2024
@openjdk openjdk bot closed this Jan 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@luchenlin Pushed as commit 325fc37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants