Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication #2428

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 3, 2024

I backport this for parity with 11.0.23-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8309119 needs maintainer approval

Issue

  • JDK-8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2428/head:pull/2428
$ git checkout pull/2428

Update a local copy of the PR:
$ git checkout pull/2428
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2428

View PR using the GUI difftool:
$ git pr show -t 2428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2428.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a6ef655b6f98fc2e1c4aa04525b91485b372aaff 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 3c732a6: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.
  • de6ccb9: 8294402: Add diagnostic logging to VMProps.checkDockerSupport
  • f6ddc4b: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM
  • 94bf6db: 8202790: DnD test DisposeFrameOnDragTest.java does not clean up
  • 8ca3b77: 8322417: Console read line with zero out should zero out when throwing exception
  • 4031a88: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails
  • 9a16bee: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt
  • ed37e2d: 8208243: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java fails in jdk/hs nightly
  • e3b6c50: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 78ca5ec: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/2a96f76919a416e2935636291400e1032d8b1993...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 8, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit c759b2e.
Since your change was applied there have been 13 commits pushed to the master branch:

  • c342a03: 8313643: Update HarfBuzz to 8.2.2
  • 3c732a6: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.
  • de6ccb9: 8294402: Add diagnostic logging to VMProps.checkDockerSupport
  • f6ddc4b: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM
  • 94bf6db: 8202790: DnD test DisposeFrameOnDragTest.java does not clean up
  • 8ca3b77: 8322417: Console read line with zero out should zero out when throwing exception
  • 4031a88: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails
  • 9a16bee: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt
  • ed37e2d: 8208243: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java fails in jdk/hs nightly
  • e3b6c50: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/2a96f76919a416e2935636291400e1032d8b1993...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@GoeLin Pushed as commit c759b2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant