Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt #2431

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jan 4, 2024

I backport this for parity with 11.0.23-oracle.
Not in ProblemList.txt,so make it clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8310551 needs maintainer approval

Issue

  • JDK-8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2431/head:pull/2431
$ git checkout pull/2431

Update a local copy of the PR:
$ git checkout pull/2431
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2431

View PR using the GUI difftool:
$ git pr show -t 2431

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2431.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c84866ac0dcda487fe2abc2a8841f237df0a395b 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2024

Webrevs

@luchenlin
Copy link
Contributor Author

/clean

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@luchenlin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member

GoeLin commented Jan 5, 2024

Hi @luchenlin,
It would be better to base your backport on the jdk17u backport.
That also does not have the change to the ProblemList.
If you use the hash from the push to 17u in the PR title, it should be recognized as clean automatically.

@openjdk
Copy link

openjdk bot commented Jan 7, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • ed37e2d: 8208243: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java fails in jdk/hs nightly
  • e3b6c50: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 78ca5ec: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails
  • 888837a: 8315042: NPE in PKCS7.parseOldSignedData

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 7, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

Going to push as commit 9a16bee.
Since your change was applied there have been 4 commits pushed to the master branch:

  • ed37e2d: 8208243: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java fails in jdk/hs nightly
  • e3b6c50: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 78ca5ec: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails
  • 888837a: 8315042: NPE in PKCS7.parseOldSignedData

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 8, 2024
@openjdk openjdk bot closed this Jan 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@luchenlin Pushed as commit 9a16bee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants