Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274621: NullPointerException because listenAddress[0] is null #2441

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jan 9, 2024

I backport this for parity with 11.0.23-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8274621 needs maintainer approval

Issue

  • JDK-8274621: NullPointerException because listenAddress[0] is null (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2441/head:pull/2441
$ git checkout pull/2441

Update a local copy of the PR:
$ git checkout pull/2441
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2441/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2441

View PR using the GUI difftool:
$ git pr show -t 2441

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2441.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5bbc8d3cb2ce487b367ee1a621d78699c9b30100 8274621: NullPointerException because listenAddress[0] is null Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274621: NullPointerException because listenAddress[0] is null

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 224f0f3: 6928542: Chinese characters in RTF are not decoded
  • e3a18fa: 8322772: Clean up code after JDK-8322417
  • 58b154e: 8322725: (tz) Update Timezone Data to 2023d
  • 666bf87: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode
  • c759b2e: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication
  • c342a03: 8313643: Update HarfBuzz to 8.2.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 10, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

Going to push as commit 8a1e29d.
Since your change was applied there have been 7 commits pushed to the master branch:

  • c360cd5: 8306753: Open source several container AWT tests
  • 224f0f3: 6928542: Chinese characters in RTF are not decoded
  • e3a18fa: 8322772: Clean up code after JDK-8322417
  • 58b154e: 8322725: (tz) Update Timezone Data to 2023d
  • 666bf87: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode
  • c759b2e: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication
  • c342a03: 8313643: Update HarfBuzz to 8.2.2

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2024
@openjdk openjdk bot closed this Jan 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@luchenlin Pushed as commit 8a1e29d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant