Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322772: Clean up code after JDK-8322417 #2443

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jan 9, 2024

Hi all,

This pull request contains a backport of JDK-8322772, commit bfd23aea from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Christoph Langer on 9 Jan 2024 and was reviewed by Matthias Baesken.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322772 needs maintainer approval

Issue

  • JDK-8322772: Clean up code after JDK-8322417 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2443/head:pull/2443
$ git checkout pull/2443

Update a local copy of the PR:
$ git checkout pull/2443
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2443/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2443

View PR using the GUI difftool:
$ git pr show -t 2443

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2443.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bfd23aeae1566b86c20bdcbecff58f216947612a 8322772: Clean up code after JDK-8322417 Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8322772: Clean up code after JDK-8322417

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 9, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit e3a18fa.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 58b154e: 8322725: (tz) Update Timezone Data to 2023d
  • 666bf87: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode
  • c759b2e: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication
  • c342a03: 8313643: Update HarfBuzz to 8.2.2

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@RealCLanger Pushed as commit e3a18fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant