8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries

[GoeLin]

This is a backout needed as the change is too intrusive for a backport.
Backport of the 17 change.

This is not clean because in 11

• an extra import was needed
• a """ string was adapted to 11 syntax

The backout was crafted with two git revert commands.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8322883 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries (Bug - P3 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2450/head:pull/2450
$ git checkout pull/2450

Update a local copy of the PR:
$ git checkout pull/2450
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2450/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2450

View PR using the GUI difftool:
$ git pr show -t 2450

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2450.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (a8bded8c)

[TheRealMDoerr]

LGTM.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 8aa5509: 8307381: Open Source JFrame, JIF related Swing Tests
• 3bb03ee: 8306871: Open source more AWT Drag & Drop tests
• 7262e7d: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2
• e7f17f1: 8306076: Open source AWT misc tests
• e55aac2: 8259801: Enable XML Signature secure validation mode by default

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit ff6e6d7.
Since your change was applied there have been 6 commits pushed to the master branch:

• 1f3c7d5: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop
• 8aa5509: 8307381: Open Source JFrame, JIF related Swing Tests
• 3bb03ee: 8306871: Open source more AWT Drag & Drop tests
• 7262e7d: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2
• e7f17f1: 8306076: Open source AWT misc tests
• e55aac2: 8259801: Enable XML Signature secure validation mode by default

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit ff6e6d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.