-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader #2454
Conversation
👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
@benty-amzn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@benty-amzn This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Hi @benty-amzn, will you continue on this? |
I'll continue on this after #2612 is merged, which will prevent the need to rewrite the included junit test |
That makes sense, thanks! |
/open |
Seems the bot doesn't want to reopen this, so I've created #2619 instead |
Clean backport of JDK-8319436 to resolve a regression introduced in 11.0.20.
Included test passes locally on linux x64 after the update to jtreg-7.3.1
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2454/head:pull/2454
$ git checkout pull/2454
Update a local copy of the PR:
$ git checkout pull/2454
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2454/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2454
View PR using the GUI difftool:
$ git pr show -t 2454
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2454.diff
Webrev
Link to Webrev Comment