Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader #2454

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link
Contributor

@benty-amzn benty-amzn commented Jan 10, 2024

Clean backport of JDK-8319436 to resolve a regression introduced in 11.0.20.
Included test passes locally on linux x64 after the update to jtreg-7.3.1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319436 needs maintainer approval

Issue

  • JDK-8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2454/head:pull/2454
$ git checkout pull/2454

Update a local copy of the PR:
$ git checkout pull/2454
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2454

View PR using the GUI difftool:
$ git pr show -t 2454

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2454.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2024

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8eb6f617b3f8e2a990e4244af4e56287f9741b20 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

⚠️ @benty-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Jan 10, 2024

Webrevs

@openjdk openjdk bot removed the approval label Jan 11, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2024

@benty-amzn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2024

@benty-amzn This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Mar 7, 2024
@GoeLin
Copy link
Member

GoeLin commented Mar 20, 2024

Hi @benty-amzn, will you continue on this?

@benty-amzn
Copy link
Contributor Author

I'll continue on this after #2612 is merged, which will prevent the need to rewrite the included junit test

@GoeLin
Copy link
Member

GoeLin commented Mar 20, 2024

That makes sense, thanks!

@benty-amzn
Copy link
Contributor Author

/open

@benty-amzn
Copy link
Contributor Author

Seems the bot doesn't want to reopen this, so I've created #2619 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants