8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows

[yukikimmura]

I would like to fix this issue because the test dose not work as intended.
8318410 resolved two issues. However, the first issue related to JEP400 is not relevant to JDK11.
Therefore, I would like to backport only the second issue,
which is the problem of tests not running properly on Windows cygwin.
Backporting to JDK11 is the same as backporting to JDK17 which has already done.

Could someone please review it?

Thanks,
Kimura Yukihiro

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8318410 needs maintainer approval

Issue

• JDK-8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2456/head:pull/2456
$ git checkout pull/2456

Update a local copy of the PR:
$ git checkout pull/2456
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2456/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2456

View PR using the GUI difftool:
$ git pr show -t 2456

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2456.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (f633617f)

[GoeLin]

HI,
you are missing a review. Don't label before you have a review.
If it's identical to the 17u backport, base it on that commit and it is clean, and you need no review.
Retroactively you can fix this by editing the title of this PR to be "Backport <hash of push to 17>".
The bots will first issue an error that they did not find the hash, but after a while (>2h) they will manage.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @yukikimmura This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[yukikimmura]

Hello Goetz,
Thank you for your advice.
I deleted the Fix Request 11u label, and changed the tittle of this PR.

Thanks,
Kimura Yukihiro

[yukikimmura]

/approval request I would like to backport this issue to 11u,
because the test dose not work as intended on some Windows environment,
and it always fails in regression testing, resulting in extra costs for checking the test results,
The fix applis cleanly to 11u from 17u,
There is no risk because backporting to JDK11 is the same as backporting to JDK17 which has already done,
and I verified the fix enough,
Testing: I tested BootClassPathTest on Windows(English,Japanese) and Linux(LANG/LC_ALL/LC_CTYPE=C,en_US.UTF-8,ja_JP.utf8).

[openjdk]

@yukikimmura
8318410: The approval request has been created successfully.

[openjdk]

@yukikimmura This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• dc028f2: 8323008: filter out harmful -std* flags added by autoconf from CXX
• 51d944e: 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return
• 0e8244b: 8315594: Open source few headless Swing misc tests
• 0f1f656: Merge
• 6739881: 8323423: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.22
• e059fc7: 8314307: Improve loop handling
• a9145c7: 8317547: Enhance TLS connection support
• 4ec94b1: 8316976: Improve signature handling
• 4576161: 8314468: Improve Compiler loops
• 6944c16: 8314295: Enhance verification of verifier
• ... and 26 more: https://git.openjdk.org/jdk11u-dev/compare/3c732a61bfc573c2c34ca9644f299a1a1a757e56...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[yukikimmura]

/integrate

[openjdk]

@yukikimmura
Your change (at version f633617) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit 1c12d16.
Since your change was applied there have been 39 commits pushed to the master branch:

• cb3c6ca: 8319124: Update XML Security for Java to 3.0.3
• 03cd885: 8169475: WheelModifier.java fails by timeout
• ef24634: 8305972: Update XML Security for Java to 3.0.2
• dc028f2: 8323008: filter out harmful -std* flags added by autoconf from CXX
• 51d944e: 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return
• 0e8244b: 8315594: Open source few headless Swing misc tests
• 0f1f656: Merge
• 6739881: 8323423: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.22
• e059fc7: 8314307: Improve loop handling
• a9145c7: 8317547: Enhance TLS connection support
• ... and 29 more: https://git.openjdk.org/jdk11u-dev/compare/3c732a61bfc573c2c34ca9644f299a1a1a757e56...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @yukikimmura Pushed as commit 1c12d16.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.