Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318154: Improve stability of WheelModifier.java test #2459

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jan 16, 2024

I backport this for parity with 11.0.23-oracle.


Progress

  • JDK-8318154 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318154: Improve stability of WheelModifier.java test (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2459/head:pull/2459
$ git checkout pull/2459

Update a local copy of the PR:
$ git checkout pull/2459
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2459/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2459

View PR using the GUI difftool:
$ git pr show -t 2459

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2459.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 668d4b077f260a30a90842a01b38a9cf6718d418 8318154: Improve stability of WheelModifier.java test Jan 16, 2024
@openjdk
Copy link

openjdk bot commented Jan 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 16, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 16, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 16, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8318154: Improve stability of WheelModifier.java test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 499e1c1: 8320208: Update Public Suffix List to b5bf572
  • ff6e6d7: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 17, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

Going to push as commit 621a5e5.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 499e1c1: 8320208: Update Public Suffix List to b5bf572
  • ff6e6d7: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2024
@openjdk openjdk bot closed this Jan 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@luchenlin Pushed as commit 621a5e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant