Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" #2486

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Jan 26, 2024

Hi all,

This pull request contains a backport of commit 4d078930 from the openjdk/jdk21u repository & the clean backport commit 4f80edf from 17u. A new bug ID, JDK-8324184, had to be created as JDK-8317331, the original bug, is private.

The commit being backported was authored by Coleen Phillimore on 2 Oct 2023 and had no reviewers.

We hit this issue in 8u, where the VS2010 build seems to be broken because of the placing of the declarations of low, high and index in JDK-8314295; see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7549766959/job/20554342418. The name of the private bug fix, JDK-8317331: Solaris build failed with "declaration can not follow a statement (E_DECLARATION_IN_CODE)", suggests it is also an issue on Solaris which is still supported by 8u & 11u.

Backport was clean and built fine on GNU/Linux with GCC 13.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8324184 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2486/head:pull/2486
$ git checkout pull/2486

Update a local copy of the PR:
$ git checkout pull/2486
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2486

View PR using the GUI difftool:
$ git pr show -t 2486

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2486.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2024

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4f80edfae10e83f2709f297a553d2128712e4b51 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2024

Webrevs

@tstuefe
Copy link
Member

tstuefe commented Jan 26, 2024

I think VS2010 does not implement C99, which brought middle-of-the-block variable declarations.

@gnu-andrew
Copy link
Member Author

I think VS2010 does not implement C99, which brought middle-of-the-block variable declarations.

Yes, it's not the first time we've encountered this sort of failure (and Oracle too). I seem to recall that the failure can be forced on gcc by lowering the standard, so that might be worth investigating again and adding to my own build tests, at least for 8u.

@gnu-andrew
Copy link
Member Author

/approval request Additional change from the January security update which fixes new code introduced by a security patch to compile on older C compilers that require declarations to precede statements in a block. Patch applies clean and it is preferable to keep this code consistent across all supported JDKs. In theory, this should also fix Solaris builds on 11u, if anyone still performs them.

@openjdk
Copy link

openjdk bot commented Jan 27, 2024

@gnu-andrew
8324184: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 27, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 82a1501: 8324659: GHA: Generic jtreg errors are not reported
  • b4f6177: 8315761: Open source few swing JList and JMenuBar tests
  • fbc6005: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
  • ec4e75d: 8308245: Add -proc:full to describe current default annotation processing policy
  • bee8d32: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 29, 2024
@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

Going to push as commit 26d795d.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 82a1501: 8324659: GHA: Generic jtreg errors are not reported
  • b4f6177: 8315761: Open source few swing JList and JMenuBar tests
  • fbc6005: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
  • ec4e75d: 8308245: Add -proc:full to describe current default annotation processing policy
  • bee8d32: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 29, 2024
@openjdk openjdk bot closed this Jan 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@gnu-andrew Pushed as commit 26d795d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants