Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp #2494

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jan 29, 2024

I backport this for parity with 11.0.23-oracle.
Only add the '@requires', make it clean.


Progress

  • JDK-8314144 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2494/head:pull/2494
$ git checkout pull/2494

Update a local copy of the PR:
$ git checkout pull/2494
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2494

View PR using the GUI difftool:
$ git pr show -t 2494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2494.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1925508425cf1b2d46173754077a588290253430 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 29, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2024

Webrevs

@luchenlin
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@luchenlin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 4fe0b83: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location
  • 46e4ad2: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
  • 54a1c84: 8316106: Open source few swing JInternalFrame and JMenuBar tests
  • 80b00ca: 8209595: MonitorVmStartTerminate.java timed out
  • 3a0c820: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
  • b1bdadd: 8315600: Open source few more headless Swing misc tests
  • 34ea901: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • c97f19a: 8272552: mark hotspot runtime/cds tests which ignore external VM flags
  • a4d416e: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • c9a30d0: 8246222: Rename javac test T6395981.java to be more informative
  • ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/ec4e75d81a3661df3dbf43610cba69c453099082...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 30, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

Going to push as commit 57e3a82.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 54ada10: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • 6922a60: 8156889: ListKeychainStore.sh fails in some virtualized environments
  • 9379be4: 8309870: Using -proc:full should be considered requesting explicit annotation processing
  • 4fe0b83: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location
  • 46e4ad2: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
  • 54a1c84: 8316106: Open source few swing JInternalFrame and JMenuBar tests
  • 80b00ca: 8209595: MonitorVmStartTerminate.java timed out
  • 3a0c820: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
  • b1bdadd: 8315600: Open source few more headless Swing misc tests
  • 34ea901: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/ec4e75d81a3661df3dbf43610cba69c453099082...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 31, 2024
@openjdk openjdk bot closed this Jan 31, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@luchenlin Pushed as commit 57e3a82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant