Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314220: Configurable InlineCacheBuffer size #2498

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link

@kvergizova kvergizova commented Jan 29, 2024

I'd like to backport JDK-8314220 to 11u.
It allows to configure IC buffer size to avoid multiple ICBufferFull safepoints and possible performance degradation.

17u patch applies almost cleanly except for:

  • minor context difference in icBuffer.cpp
  • different method for experimental flag declaration in globals.hpp (JDK-8243208 is not in 11u)
    The changes reapplied manually.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314220 needs maintainer approval

Issue

  • JDK-8314220: Configurable InlineCacheBuffer size (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2498/head:pull/2498
$ git checkout pull/2498

Update a local copy of the PR:
$ git checkout pull/2498
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2498/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2498

View PR using the GUI difftool:
$ git pr show -t 2498

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2498.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2024

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a40d8d97e84d88d1a65aba81bfc09339be95e427 8314220: Configurable InlineCacheBuffer size Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 29, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2024

@kvergizova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

⚠️ @kvergizova This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8314220: Configurable InlineCacheBuffer size

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 88 new commits pushed to the master branch:

  • 7b7fbdf: 8267938: (sctp) SCTP channel factory methods should check platform support
  • f3069d1: 8325972: Add -x to bash for building with LOG=debug
  • b425dff: 8320303: Allow PassFailJFrame to accept single window creator
  • bc14b9f: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
  • 4ef8db8: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • 6c0a88d: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
  • 2a78f2f: Merge
  • 5c5687d: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • a4a5c7f: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
  • ... and 78 more: https://git.openjdk.org/jdk11u-dev/compare/26d795d794e8ec996e36190b56969cdaf5b9d810...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 11, 2024
@kvergizova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

Going to push as commit c8ca55b.
Since your change was applied there have been 94 commits pushed to the master branch:

  • e6cec8f: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • eb5ef84: 8315677: Open source few swing JFileChooser and other tests
  • cf9aa9b: 8306941: Open source several datatransfer and dnd AWT tests
  • 9b40856: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
  • fbac37b: 8307083: Open source some drag and drop tests 3
  • a26445d: 8261404: Class.getReflectionFactory() is not thread-safe
  • 7b7fbdf: 8267938: (sctp) SCTP channel factory methods should check platform support
  • f3069d1: 8325972: Add -x to bash for building with LOG=debug
  • b425dff: 8320303: Allow PassFailJFrame to accept single window creator
  • bc14b9f: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
  • ... and 84 more: https://git.openjdk.org/jdk11u-dev/compare/26d795d794e8ec996e36190b56969cdaf5b9d810...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2024
@openjdk openjdk bot closed this Mar 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@kvergizova Pushed as commit c8ca55b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants