8267938: (sctp) SCTP channel factory methods should check platform support

[theaoqi]

Hi all,

I would like to backport JDK-8267938. According to the bug description, 11(.0.11) is also affected. java/net/SctpSanity.java can reproduce this problem. The backport is clean except copyright year. GHA testing is passed.

Additional testing, no regression introduced by this backport:

• Linux x86_64 server release, tier1 tier2 tier3
• Linux x86_64 server fastdebug, tier1 tier2 tier3

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8267938 needs maintainer approval

Issue

• JDK-8267938: (sctp) SCTP channel factory methods should check platform support (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2500/head:pull/2500
$ git checkout pull/2500

Update a local copy of the PR:
$ git checkout pull/2500
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2500

View PR using the GUI difftool:
$ git pr show -t 2500

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2500.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @theaoqi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (8bb066ec)

[bridgekeeper]

@theaoqi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[theaoqi]

/approval request Clean backport except copyright year. According to the bug description, 11(.0.11) is also affected. java/net/SctpSanity.java can reproduce this problem. GHA testing and additional testing (tier1-3) are passed. The backport affects exception handling to provide more accurate exceptions, so I think the risk is low.

[openjdk]

@theaoqi
8267938: The approval request has been created successfully.

[openjdk]

@theaoqi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267938: (sctp) SCTP channel factory methods should check platform support

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

• a4a5c7f: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
• f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
• a582e11: 8281507: Two javac tests have bad jtreg @clean tags
• b183cd2: 8314552: Fix javadoc tests to work with jtreg 7
• 0ae93db: 8323717: Introduce test keyword for tests that need external dependencies
• 61164ce: 8305962: update jcstress to 0.16
• f2565a6: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• 0e94be6: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
• 2dee6fb: 8294156: Allow PassFailJFrame.Builder to create test UI
• c681c5a: 8316053: Open some swing tests 3
• ... and 70 more: https://git.openjdk.org/jdk11u-dev/compare/26d795d794e8ec996e36190b56969cdaf5b9d810...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[theaoqi]

/integrate

[openjdk]

@theaoqi
Your change (at version 8bb066e) is now ready to be sponsored by a Committer.

[theaoqi]

@GoeLin, thanks for the approval, and could you help to sponsor?

[phohensee]

/sponsor

[openjdk]

Going to push as commit 7b7fbdf.
Since your change was applied there have been 87 commits pushed to the master branch:

• f3069d1: 8325972: Add -x to bash for building with LOG=debug
• b425dff: 8320303: Allow PassFailJFrame to accept single window creator
• bc14b9f: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
• 4ef8db8: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
• 6c0a88d: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
• 2a78f2f: Merge
• 5c5687d: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
• a4a5c7f: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
• f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
• a582e11: 8281507: Two javac tests have bad jtreg @clean tags
• ... and 77 more: https://git.openjdk.org/jdk11u-dev/compare/26d795d794e8ec996e36190b56969cdaf5b9d810...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @theaoqi Pushed as commit 7b7fbdf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.