8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id

[jia-wei-tang]

It isn't a clean backport for two reasons.

1. jdk11 cannot use nullptr, so it should use NULL instead.
2. parent_thread_group_handle != NULL will cause a compile error without a type cast.

This backport prevents a JFR operation from accessing an illegal address which has not be filled before the initialization of a JavaThread, which is created from a JNI interface.

The risk is very low since it only adds a null pointer check. Besides, This backport has be accepted in jdk17-dev.

Additional testing:

• Linux aarch64 server fastdebug, test/jdk/jdk/jfr passed

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8276125 needs maintainer approval

Issue

• JDK-8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id (Bug - P3 - Approved)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2501/head:pull/2501
$ git checkout pull/2501

Update a local copy of the PR:
$ git checkout pull/2501
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2501/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2501

View PR using the GUI difftool:
$ git pr show -t 2501

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2501.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jia-wei-tang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (e720c8a6)
• 01: Full - Incremental (a929af31)
• 00: Full (89e822d4)

[openjdk]

@jia-wei-tang Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[jia-wei-tang]

/integrate

[openjdk]

@jia-wei-tang This pull request has not yet been marked as ready for integration.

[jia-wei-tang]

Is there any reviewer available to help with the review? Thanks a lot!

[GoeLin]

Please get a review before labeling fix-request.

[jia-wei-tang]

@egahlin @mgronlun Could you help review the backport related to JFR? The reasons for changing the original backport codes and the related Jtreg tests results have been presented before. Thank you very much.

[jia-wei-tang]

@GoeLin Could you help with this review? In our application, we can stably reproduce this JVM crash. And this PR just backport a null condition check from JDK17. This is really simple and harmless. Thank you very much.

[openjdk]

⚠️ @jia-wei-tang the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout my-backport-branch
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@jia-wei-tang This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

• f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
• a582e11: 8281507: Two javac tests have bad jtreg @clean tags
• b183cd2: 8314552: Fix javadoc tests to work with jtreg 7
• 0ae93db: 8323717: Introduce test keyword for tests that need external dependencies
• 61164ce: 8305962: update jcstress to 0.16
• f2565a6: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• 0e94be6: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
• 2dee6fb: 8294156: Allow PassFailJFrame.Builder to create test UI
• c681c5a: 8316053: Open some swing tests 3
• e5cc20c: 8315726: Open source several AWT applet tests
• ... and 69 more: https://git.openjdk.org/jdk11u-dev/compare/26d795d794e8ec996e36190b56969cdaf5b9d810...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mgronlun) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jia-wei-tang]

/integrate

[openjdk]

@jia-wei-tang
Your change (at version e720c8a) is now ready to be sponsored by a Committer.

[DamonFool]

/sponsor

[openjdk]

Going to push as commit a4a5c7f.
Since your change was applied there have been 79 commits pushed to the master branch:

• f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
• a582e11: 8281507: Two javac tests have bad jtreg @clean tags
• b183cd2: 8314552: Fix javadoc tests to work with jtreg 7
• 0ae93db: 8323717: Introduce test keyword for tests that need external dependencies
• 61164ce: 8305962: update jcstress to 0.16
• f2565a6: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• 0e94be6: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
• 2dee6fb: 8294156: Allow PassFailJFrame.Builder to create test UI
• c681c5a: 8316053: Open some swing tests 3
• e5cc20c: 8315726: Open source several AWT applet tests
• ... and 69 more: https://git.openjdk.org/jdk11u-dev/compare/26d795d794e8ec996e36190b56969cdaf5b9d810...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool @jia-wei-tang Pushed as commit a4a5c7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.