Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 #2510

Closed
wants to merge 2 commits into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Feb 6, 2024

Backport of JDK-8274122

  • This PR has 2 commits
    • The first commit is a clean git apply
    • The second commit is Compile error fix on Java 11
  • Clean from jdk17u-dev

Testing

  • Local: Test in progress
    • MacOS - SpecialTempFile.java: Test results: passed: 1
    • Windows - SpecialTempFile.java: Test results: passed: 1
Edition	Windows 11 Enterprise
Version	23H2
Installed on	‎5/‎10/‎2023
OS build	22631.3007
Experience	Windows Feature Experience Pack 1000.22681.1000.0
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-02-11

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8274122 needs maintainer approval

Issue

  • JDK-8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2510/head:pull/2510
$ git checkout pull/2510

Update a local copy of the PR:
$ git checkout pull/2510
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2510

View PR using the GUI difftool:
$ git pr show -t 2510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2510.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4a142c3b0831d60b3d5540f58973e8ad3d1304bf 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 Feb 6, 2024
@openjdk
Copy link

openjdk bot commented Feb 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 6, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 6, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 7, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@amosshi
Copy link
Contributor Author

amosshi commented Feb 12, 2024

/approval request “Backporting for parity with jdk 11.0.23-oracle. Un-Clean backport. Test case only, no risk. SAP nightlies passed on 2024-02-11”

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@amosshi
8274122: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • a60a5c4: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • 93c5f7c: 8326503: [11u] java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fail because of package org.junit.jupiter.api does not exist
  • 8dc2892: 8323515: Create test alias "all" for all test roots
  • e075097: 8294158: HTML formatting for PassFailJFrame instructions
  • ea06b5c: 8321480: ISO 4217 Amendment 176 Update
  • 776f1e3: 8294535: Add screen capture functionality to PassFailJFrame
  • 6711fc8: 8321408: Add Certainly roots R1 and E1
  • 43a56c8: 8307299: Move more DnD tests to open
  • fe8c20c: 8306681: Open source more AWT DnD related tests
  • 30dfe81: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • ... and 27 more: https://git.openjdk.org/jdk11u-dev/compare/4c25b228c95aab583329c12129c19819507b480f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 21, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Feb 22, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@amosshi
Your change (at version 300f766) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Feb 22, 2024

Hi @amosshi,
please make this a backport from 17 by editing the title and using the commit has of 17. This should be clean then.

@amosshi amosshi changed the title 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 Backport d6ad2f1715757bc289cc16c78680f515aec78a6d Feb 26, 2024
@openjdk openjdk bot changed the title Backport d6ad2f1715757bc289cc16c78680f515aec78a6d 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the clean label Feb 26, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Feb 26, 2024

Hi @amosshi, please make this a backport from 17 by editing the title and using the commit has of 17. This should be clean then.

HI @GoeLin , Done. Now this PR is clean from jdk17u-dev

@GoeLin
Copy link
Member

GoeLin commented Feb 27, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 27, 2024

Going to push as commit 7bed7f1.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 10f0884: 8207855: Make applications/jcstress invoke tests in batches
  • a855cab: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
  • a60a5c4: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • 93c5f7c: 8326503: [11u] java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fail because of package org.junit.jupiter.api does not exist
  • 8dc2892: 8323515: Create test alias "all" for all test roots
  • e075097: 8294158: HTML formatting for PassFailJFrame instructions
  • ea06b5c: 8321480: ISO 4217 Amendment 176 Update
  • 776f1e3: 8294535: Add screen capture functionality to PassFailJFrame
  • 6711fc8: 8321408: Add Certainly roots R1 and E1
  • 43a56c8: 8307299: Move more DnD tests to open
  • ... and 29 more: https://git.openjdk.org/jdk11u-dev/compare/4c25b228c95aab583329c12129c19819507b480f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 27, 2024
@openjdk openjdk bot closed this Feb 27, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 27, 2024
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 27, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@GoeLin @amosshi Pushed as commit 7bed7f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8274122 branch April 9, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants