Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException #2521

Closed
wants to merge 2 commits into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Feb 8, 2024

Backport of JDK-8161536

  • This PR has two commits
  • Commit 1 is a clean back port of original commit
  • Commit 2 is the fix for test case error ClassNotFoundException: allow

Testing

  • Local: Passed
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-02-11 on the following environment
    • NTAMD64
    • linuxppc64le
    • linuxx86_64
    • linuxaarch64
    • darwinintel64
    • darwinaarch64

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8161536 needs maintainer approval

Issue

  • JDK-8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2521/head:pull/2521
$ git checkout pull/2521

Update a local copy of the PR:
$ git checkout pull/2521
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2521

View PR using the GUI difftool:
$ git pr show -t 2521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2521.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 939d7c5d8466f9e392beae2947a494ac28695cc1 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 8, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a backport of JDK-8161536. The original change removes ClientJSSEServerJSSE.java from problem list, this PR adds it.

@amosshi amosshi closed this Feb 26, 2024
@amosshi amosshi deleted the backport-8161536 branch February 26, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants