Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java #2522

Closed
wants to merge 3 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Feb 12, 2024

Hi all,

This pull request contains a backport of commit 6c7029ff from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 10 Feb 2024 and was reviewed by Alexey Ivanov and Aleksey Shipilev.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318603 needs maintainer approval

Issue

  • JDK-8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2522/head:pull/2522
$ git checkout pull/2522

Update a local copy of the PR:
$ git checkout pull/2522
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2522/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2522

View PR using the GUI difftool:
$ git pr show -t 2522

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2522.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6c7029ffd48186353fc1d2a03915386b5f386ae2 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 12, 2024
@mrserb mrserb marked this pull request as ready for review February 12, 2024 10:35
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 12, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2024

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Feb 12, 2024

The patch for jdk11u is not clean, because it has 8 subtests. 4 tests were removed in jdk17u by the JDK-8259681 which is not backported to the jdk11u.
Since the number of subtests is different the result is even better than in jdk17+, all headless tests from jdk_desktop group(1,659 tests):

BASE:
real    10m55.451s
user    114m0.921s
sys     7m20.256s

FIX:
real    4m5.265s
user    116m14.452s
sys     7m17.951s

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 621048a: 8247818: GCC 10 warning stringop-overflow with symbol code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 15, 2024
@mrserb
Copy link
Member Author

mrserb commented Feb 16, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

Going to push as commit 1047521.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 1f516f6: 8324307: [11u] hotspot fails to build with GCC 12 and newer (non-static data member initializers)
  • bcdad92: 8249087: Always initialize _body[0..1] in Symbol constructor
  • daf393a: 8304725: AsyncGetCallTrace can cause SIGBUS on M1
  • 621048a: 8247818: GCC 10 warning stringop-overflow with symbol code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2024
@openjdk openjdk bot closed this Feb 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@mrserb Pushed as commit 1047521.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the backport-mrserb-6c7029ff branch February 16, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants