8321480: ISO 4217 Amendment 176 Update

[gnu-andrew]

Hi all,

This pull request contains a backport of commit 223018a3 from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Andrew Lu on 6 Feb 2024 and was reviewed by Matthias Baesken.

The changes are mostly clean. The differences are a different copyright header in make/jdk/src/classes/build/tools/generatecurrencydata/GenerateCurrencyData.java and the absent refactoring of test/jdk/java/util/Currency/ValidateISO4217.java

As discussed on #2503, bringing in the refactoring also requires bumping JTreg, which in turn requires fixes to a number of other tests. To get this update in for 11.0.23 before rampdown, I think we can make the same code addition in ValidateISO4217.java (with different alignment) and defer the change to twoLetterCodesTest to JDK-8310923 on #2503.

The java.util.Currency tests all pass with this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8321480 needs maintainer approval

Issue

• JDK-8321480: ISO 4217 Amendment 176 Update (Bug - P3 - Approved)

Reviewers

• Goetz Lindenmaier (@GoeLin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2532/head:pull/2532
$ git checkout pull/2532

Update a local copy of the PR:
$ git checkout pull/2532
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2532

View PR using the GUI difftool:
$ git pr show -t 2532

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2532.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (6cf762e5)

[GoeLin]

LGTM. Also passed SAP's testing.

[openjdk]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[gnu-andrew]

Thanks Goetz.
/approval request Regular ISO 4217 update. Patch is mostly clean, bar some workarounds for the absence of the JDK-8310923 refactoring at present, which has a long tail of associated fixes to get in first. Patch was reviewed by Goetz.

[openjdk]

@gnu-andrew
8321480: The approval request has been created successfully.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8321480: ISO 4217 Amendment 176 Update

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 6711fc8: 8321408: Add Certainly roots R1 and E1
• 43a56c8: 8307299: Move more DnD tests to open
• fe8c20c: 8306681: Open source more AWT DnD related tests
• 30dfe81: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
• 1b207cc: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
• f4cf239: 8315602: Open source swing security manager test
• 398f486: 8306812: Open source several AWT Miscellaneous tests
• aeb6381: 8306640: Open source several AWT TextArea related tests
• 9724132: 8306752: Open source several container and component AWT tests
• c905214: 8306755: Open source few Swing JComponent and AbstractButton tests
• ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/de3ae6f26507f0ed8a7af00ad93fdf78da77dad2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gnu-andrew]

/integrate

[openjdk]

Going to push as commit ea06b5c.
Since your change was applied there have been 12 commits pushed to the master branch:

• 776f1e3: 8294535: Add screen capture functionality to PassFailJFrame
• 6711fc8: 8321408: Add Certainly roots R1 and E1
• 43a56c8: 8307299: Move more DnD tests to open
• fe8c20c: 8306681: Open source more AWT DnD related tests
• 30dfe81: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
• 1b207cc: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
• f4cf239: 8315602: Open source swing security manager test
• 398f486: 8306812: Open source several AWT Miscellaneous tests
• aeb6381: 8306640: Open source several AWT TextArea related tests
• 9724132: 8306752: Open source several container and component AWT tests
• ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/de3ae6f26507f0ed8a7af00ad93fdf78da77dad2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit ea06b5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.