-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8323515: Create test alias "all" for all test roots #2543
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/approval JDK-8323515 request Improves JDK 11u testability by allowing to run all tests at once. There was a contextual conflict, resolved manually. Test groups sanity is tested with GHA. |
|
Hi @shipilev, I assume the follow up JDK-8324647 is not needed in 11? |
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 34 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 8dc2892.
Your commit was automatically rebased without conflicts. |
Improves JDK 17u testability by allowing to run all tests at once. There was a contextual conflict in langtools definitions, which misses most of the definitions added later with JDK-8267162. Also, libtest testgroup is defined only later with JDK-8211977. Test groups sanity is going to be tested with GHA.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2543/head:pull/2543
$ git checkout pull/2543
Update a local copy of the PR:
$ git checkout pull/2543
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2543/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2543
View PR using the GUI difftool:
$ git pr show -t 2543
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2543.diff
Webrev
Link to Webrev Comment