-
Notifications
You must be signed in to change notification settings - Fork 238
8326564: Problem list HttpURLConnectionExpectContinueTest.java due to 8326503 #2545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…st.java fail because of package org.junit.jupiter.api does not exist Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
Only change the ProblemList.txt, the risk is low. |
Webrevs
|
It is better to make a subtask of 8326503 for this called "Problem list HttpURLConnectionExpectContinueTest.java due to 8326503". The bugid used in the ProblemList should point to an open bug. |
… the ProblemList should point to an open bug Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
Thank you for your correction, the subtask has been created. |
… 8326503 Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@sendaoYan usage: |
/approval JDK-8326564 request The testcase java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java should be excluded util JDK-8326503 is fixed |
@sendaoYan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@sendaoYan This change is no longer ready for integration - check the PR body for details. |
/integrate |
@sendaoYan |
Perhaps we should push the test fix instead? See #2553 (avoids the unexclude hand-shake). |
Can this be pushed today or tomorrow? If so that's the best I think. |
That should be doable, yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
We've pushed a fix with #2553 so this is no longer needed. |
OK |
The testcase java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java was newly added, it's backport from jdk23.
This testcase rely on jtreg-7, and it will fail run by jtreg-6: error: package org.junit.jupiter.api does not exist
If I use jtreg7 instead of jtreg6 to run all the testcases of jdk11u-dev, there are 424 testcases fail.
There are a total of 2 types failure:
1.javax/xml/jaxp testcases fail because of
java.security.AccessControlException: access denied (“java.util.PropertyPermission” “testng.thread.affinity” “read”)
2. 5 tools/javac testcases fails, such as tools/javac/6257443/T6257443.java, the fail message is:
Error. Parse Exception: Bad classname provided for
clean’: foo.package-info`So, the solution that use jtreg-7 instead of jtreg-6 is unacctable. Util we found a good solution to run this testcase success, this testcase should be excluded.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2545/head:pull/2545
$ git checkout pull/2545
Update a local copy of the PR:
$ git checkout pull/2545
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2545/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2545
View PR using the GUI difftool:
$ git pr show -t 2545
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2545.diff
Webrev
Link to Webrev Comment