Skip to content

8326564: Problem list HttpURLConnectionExpectContinueTest.java due to 8326503 #2545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 23, 2024

The testcase java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java was newly added, it's backport from jdk23.

This testcase rely on jtreg-7, and it will fail run by jtreg-6: error: package org.junit.jupiter.api does not exist

If I use jtreg7 instead of jtreg6 to run all the testcases of jdk11u-dev, there are 424 testcases fail.
There are a total of 2 types failure:
1.javax/xml/jaxp testcases fail because of java.security.AccessControlException: access denied (“java.util.PropertyPermission” “testng.thread.affinity” “read”)
2. 5 tools/javac testcases fails, such as tools/javac/6257443/T6257443.java, the fail message is: Error. Parse Exception: Bad classname provided for clean’: foo.package-info`

So, the solution that use jtreg-7 instead of jtreg-6 is unacctable. Util we found a good solution to run this testcase success, this testcase should be excluded.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326564 needs maintainer approval

Issue

  • JDK-8326564: Problem list HttpURLConnectionExpectContinueTest.java due to 8326503 (Sub-task - P4 - Requested) ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2545/head:pull/2545
$ git checkout pull/2545

Update a local copy of the PR:
$ git checkout pull/2545
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2545/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2545

View PR using the GUI difftool:
$ git pr show -t 2545

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2545.diff

Webrev

Link to Webrev Comment

…st.java fail because of package org.junit.jupiter.api does not exist

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sendaoYan
Copy link
Member Author

Only change the ProblemList.txt, the risk is low.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 23, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2024

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Feb 23, 2024

It is better to make a subtask of 8326503 for this called "Problem list HttpURLConnectionExpectContinueTest.java due to 8326503". The bugid used in the ProblemList should point to an open bug.

@sendaoYan sendaoYan changed the title 8326503: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fail because of package org.junit.jupiter.api does not exist 8326503: Problem list HttpURLConnectionExpectContinueTest.java due to 8326503 Feb 23, 2024
@sendaoYan sendaoYan changed the title 8326503: Problem list HttpURLConnectionExpectContinueTest.java due to 8326503 8326564: Problem list HttpURLConnectionExpectContinueTest.java due to 8326503 Feb 23, 2024
… the ProblemList should point to an open bug

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@sendaoYan
Copy link
Member Author

sendaoYan commented Feb 23, 2024

It is better to make a subtask of 8326503 for this called "Problem list HttpURLConnectionExpectContinueTest.java due to 8326503". The bugid used in the ProblemList should point to an open bug.

Thank you for your correction, the subtask has been created.

… 8326503

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@openjdk openjdk bot added the approval label Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@sendaoYan usage: /approval [<id>] (request|cancel) [<text>]

@sendaoYan
Copy link
Member Author

sendaoYan commented Feb 23, 2024

/approval JDK-8326564 request The testcase java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java should be excluded util JDK-8326503 is fixed

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@sendaoYan
JDK-8326564: The approval request has been created successfully.

@openjdk openjdk bot removed the approval label Feb 26, 2024
Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@sendaoYan This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 26, 2024
@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@sendaoYan
Your change (at version 89704c3) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Feb 26, 2024

Perhaps we should push the test fix instead? See #2553 (avoids the unexclude hand-shake).

@GoeLin
Copy link
Member

GoeLin commented Feb 26, 2024

Can this be pushed today or tomorrow? If so that's the best I think.
I'll revoke my fix-yes from the ProblemList change.

@openjdk openjdk bot added approval and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Feb 26, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Feb 26, 2024

Can this be pushed today or tomorrow?

That should be doable, yes.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@jerboaa
Copy link
Contributor

jerboaa commented Feb 26, 2024

We've pushed a fix with #2553 so this is no longer needed.

@sendaoYan
Copy link
Member Author

We've pushed a fix with #2553 so this is no longer needed.

OK

@sendaoYan sendaoYan closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants