Skip to content

8326594: Exclude test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Feb 23, 2024

This new test introduced by #2523 fails with JTreg 6.1, as currently used by 11u. As we won't be able to move to JTreg 7 until the 11.0.24 timeframe, we should exclude this test for 11.0.23. The test will still be present for those who want to manually run the test using a later JTreg.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326594 needs maintainer approval

Issue

  • JDK-8326594: Exclude test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2547/head:pull/2547
$ git checkout pull/2547

Update a local copy of the PR:
$ git checkout pull/2547
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2547

View PR using the GUI difftool:
$ git pr show -t 2547

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2547.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2024

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 23, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2024

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we could make the test work with jtreg 6.1. It doesn't seem like we are ready to move to jtreg 7 soon for JDK 11. Exclusion seems fine in the interim.

@@ -540,6 +540,8 @@ javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java 8042215

# jdk_net

java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java 8326549 generic-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 8326503 as the bug reference as 8326549 has been closed as a duplicate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hadn't when I filed this. That's the only bug ID I was sent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After opening my bug, I had seen the one by Sendao. I linked the two with a "duplicates" link, and asked Sendao to close one of them not knowing which one will make the race ... I think this was before you opened the sub-task. But all this is not a big deal, is it? After all, we now have a real fix!

@GoeLin
Copy link
Member

GoeLin commented Feb 26, 2024

Hi,
please note that Sendao Yan has opened this already: https://git.openjdk.org/jdk11u-dev/pull/2545

@jerboaa
Copy link
Contributor

jerboaa commented Feb 26, 2024

There is also a test fix port in the works here: #2553

@gnu-andrew gnu-andrew closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants