Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException #255

Closed
wants to merge 2 commits into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Aug 18, 2021

Backport to stabilize the test and match 11.0.13-oracle.
It contains two bugfixes that are clean backports on their own.

Additional testing:

  • Affected test still passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException
  • JDK-8226683: Remove review suggestion from fix to 8219804

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/255/head:pull/255
$ git checkout pull/255

Update a local copy of the PR:
$ git checkout pull/255
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/255/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 255

View PR using the GUI difftool:
$ git pr show -t 255

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/255.diff

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 18, 2021

/issue add JDK-8226683

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 18, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport eccfec498d4062b582282f3b73bba84206a36046 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@shipilev
Adding additional issue to issue list: 8226683: Remove review suggestion from fix to 8219804.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2021

Webrevs

Loading

Copy link
Contributor

@RealCLanger RealCLanger left a comment

LGTM

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException
8226683: Remove review suggestion from fix to 8219804

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • ba097ca: 8251549: Update docs on building for Git
  • 3a88ae7: Merge
  • 3a32efc: Merge
  • fdbaa23: Merge
  • f4772b5: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • 90d5293: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 8f402b2: 8272628: Problemlist gc/stress/gcbasher/TestGCBasherWithCMS.java for x86_32
  • 0621d9d: 8226602: Test convenience reactive primitives from java.net.http with RS TCK
  • 6722cee: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 23, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 24, 2021

Got the push approval.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

Going to push as commit b3c293c.
Since your change was applied there have been 28 commits pushed to the master branch:

  • fb886e9: 8232782: Shenandoah: streamline post-LRB CAS barrier (aarch64)
  • 5a539db: 8249548: backward focus traversal gets stuck in button group
  • da90fbb: 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter
  • f334c2e: 8263136: C4530 was reported from VS 2019 at access bridge
  • 13ddf0e: 8261072: AArch64: Fix MacroAssembler::get_thread convention
  • 4699467: 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply
  • 4a3afd7: 8248657: Windows: strengthening in ThreadCritical regarding memory model
  • 8afb159: 8250824: AArch64: follow up for JDK-8248414
  • 6a6e00e: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
  • 83d916e: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u
  • ... and 18 more: https://git.openjdk.java.net/jdk11u-dev/compare/5ce46d9679fd9c9010bcfe55fd723a0f068b3333...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@shipilev Pushed as commit b3c293c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8219804 branch Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants