Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315726: Open source several AWT applet tests #2552

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Feb 26, 2024

I backport this for parity with 11.0.23-oracle.
test/jdk/java/awt/geom/HitTest/PathHitTest.java
fix INSTRUCTIONS """ text, others' clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315726 needs maintainer approval

Issue

  • JDK-8315726: Open source several AWT applet tests (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2552/head:pull/2552
$ git checkout pull/2552

Update a local copy of the PR:
$ git checkout pull/2552
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2552

View PR using the GUI difftool:
$ git pr show -t 2552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2552.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1741d13b1260253d1e299e8da9c42b5519a7ae48 8315726: Open source several AWT applet tests Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 26, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 26, 2024

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 27, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Feb 27, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315726: Open source several AWT applet tests

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 5045b54: 8214400: Update hotspot application/jcstress jtreg tests wrappers to use jcstress 0.5
  • 6e296a0: 8326801: Bump update version for OpenJDK: jdk-11.0.24
  • 1bb3ed3: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • d2d988a: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
  • 64269a3: 8285756: clean up use of bad arguments for @clean in langtools tests
  • 7bed7f1: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11
  • 10f0884: 8207855: Make applications/jcstress invoke tests in batches
  • a855cab: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
  • a60a5c4: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • 93c5f7c: 8326503: [11u] java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fail because of package org.junit.jupiter.api does not exist
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/e075097dc849eb3b66648d2392205aecac9aeeaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 28, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

Going to push as commit e5cc20c.
Since your change was applied there have been 12 commits pushed to the master branch:

  • fe840ca: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
  • 5045b54: 8214400: Update hotspot application/jcstress jtreg tests wrappers to use jcstress 0.5
  • 6e296a0: 8326801: Bump update version for OpenJDK: jdk-11.0.24
  • 1bb3ed3: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • d2d988a: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
  • 64269a3: 8285756: clean up use of bad arguments for @clean in langtools tests
  • 7bed7f1: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11
  • 10f0884: 8207855: Make applications/jcstress invoke tests in batches
  • a855cab: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
  • a60a5c4: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/e075097dc849eb3b66648d2392205aecac9aeeaa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 28, 2024
@openjdk openjdk bot closed this Feb 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@luchenlin Pushed as commit e5cc20c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants