8261404: Class.getReflectionFactory() is not thread-safe

[Delawen]

This is a backport of https://bugs.openjdk.org/browse/JDK-8261404
8261404: Class.getReflectionFactory() is not thread-safe

Original commit openjdk/jdk@905b763

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8261404 needs maintainer approval

Issue

• JDK-8261404: Class.getReflectionFactory() is not thread-safe (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2554/head:pull/2554
$ git checkout pull/2554

Update a local copy of the PR:
$ git checkout pull/2554
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2554/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2554

View PR using the GUI difftool:
$ git pr show -t 2554

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2554.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Delawen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @Delawen This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (3ff1b5ae)

[Delawen]

/approval JDK-8261404 request Fix Request
The private method java.lang.Class.getReflectionFactory() appears to not be thread-safe. This commit fixes that.
This fix is a backport. I am applying the same fix that was done for versions 17 and 19.

[openjdk]

@Delawen
JDK-8261404: The approval request has been created successfully.

[Delawen]

@RealCLanger @GoeLin I already backported this to 17 and now I am backporting to 11. This is a clean small backport. Can any of you review it?

[GoeLin]

Hi @Delawen, it is a clean backport. If so, not review is needed.
It would be good though if you reported in the fix request comment how you tested your backport. (This one is simple, though). Thanks.

[openjdk]

@Delawen This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261404: Class.getReflectionFactory() is not thread-safe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 7b7fbdf: 8267938: (sctp) SCTP channel factory methods should check platform support
• f3069d1: 8325972: Add -x to bash for building with LOG=debug
• b425dff: 8320303: Allow PassFailJFrame to accept single window creator
• bc14b9f: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
• 4ef8db8: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
• 6c0a88d: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
• 2a78f2f: Merge
• 5c5687d: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
• a4a5c7f: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
• f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
• ... and 21 more: https://git.openjdk.org/jdk11u-dev/compare/e075097dc849eb3b66648d2392205aecac9aeeaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Delawen]

/integrate

[Delawen]

I thought I already did it, sorry for the delay.

[openjdk]

@Delawen
Your change (at version 3ff1b5a) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit a26445d.
Since your change was applied there have been 31 commits pushed to the master branch:

• 7b7fbdf: 8267938: (sctp) SCTP channel factory methods should check platform support
• f3069d1: 8325972: Add -x to bash for building with LOG=debug
• b425dff: 8320303: Allow PassFailJFrame to accept single window creator
• bc14b9f: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
• 4ef8db8: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
• 6c0a88d: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
• 2a78f2f: Merge
• 5c5687d: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
• a4a5c7f: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
• f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
• ... and 21 more: https://git.openjdk.org/jdk11u-dev/compare/e075097dc849eb3b66648d2392205aecac9aeeaa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @Delawen Pushed as commit a26445d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.