-
Notifications
You must be signed in to change notification settings - Fork 239
8285756: clean up use of bad arguments for @clean
in langtools tests
#2555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@clean
in langtools tests
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport to improve tests for jtreg update. Applies cleanly. Affected tests pass with old and new jtregs, see PR for testing details. Risk is low, test-only change. |
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 64269a3.
Your commit was automatically rebased without conflicts. |
Clean backport to improve tests for jtreg update.
Additional testing:
Progress
Issue
@<!---->clean
in langtools tests (Bug - P3 - Approved)Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2555/head:pull/2555
$ git checkout pull/2555
Update a local copy of the PR:
$ git checkout pull/2555
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2555/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2555
View PR using the GUI difftool:
$ git pr show -t 2555
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2555.diff
Webrev
Link to Webrev Comment