8281507: Two javac tests have bad jtreg @clean tags

[shipilev]

Semi-clean backport on the way to jtreg update. Both files still have source/target=6 blocks, which need to be handled as well.

Additional testing:

• Affected tests now pass with jtreg 7.3.1+1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8281507 needs maintainer approval

Issue

• JDK-8281507: Two javac tests have bad jtreg @<!---->clean tags (Bug - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2556/head:pull/2556
$ git checkout pull/2556

Update a local copy of the PR:
$ git checkout pull/2556
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2556/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2556

View PR using the GUI difftool:
$ git pr show -t 2556

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2556.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (a2912524)

[shipilev]

/approval request Semi-clean backport on the way to jtreg update. Both files still have source/target=6 blocks, which need to be handled as well, see 11u PR. Hoping to request approvals before reviews to have someone to look at the PR. Test-only change, risk is low.

[openjdk]

@shipilev
8281507: The approval request has been created successfully.

[amosshi]

Added to test environments to validate

[shipilev]

Added to test environments to validate

Not sure what that means. :) Are you testing this locally somewhere? If so, and the tests are passing, can you please formally review?

[amosshi]

Added to test environments to validate

Not sure what that means. :) Are you testing this locally somewhere? If so, and the tests are passing, can you please formally review?

HI @shipilev ,
this is Amos from SAP, there is a list of test machines in SAP office can do testings on PR in jdk11u-dev
This Jira was assigned to me last week, due to some delay and I did not pickup it. Luckily you have created this PR.
So I just added the PR to the test machines inside SAP.

I will update in this PR with comments when the test becomes green.
It takes 1-2 days usually, or could be more time, depending on the test system situations.

[shipilev]

So I am in the weird spot here: there is a maintainer approval for it, but no reviews :) Which means I still cannot integrate. @amosshi, @GoeLin -- could you please formally (R)eview this?

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8281507: Two javac tests have bad jtreg `@clean` tags

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• b183cd2: 8314552: Fix javadoc tests to work with jtreg 7
• 0ae93db: 8323717: Introduce test keyword for tests that need external dependencies
• 61164ce: 8305962: update jcstress to 0.16
• f2565a6: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• 0e94be6: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
• 2dee6fb: 8294156: Allow PassFailJFrame.Builder to create test UI
• c681c5a: 8316053: Open some swing tests 3
• e5cc20c: 8315726: Open source several AWT applet tests
• fe840ca: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
• 5045b54: 8214400: Update hotspot application/jcstress jtreg tests wrappers to use jcstress 0.5
• ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/8dc28922c2c3cec9f8b9e9ee623dbd37df748b98...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[amosshi]

Added to test environments to validate

SAP nightlies passed on 2024-02-29, 2024-03-01 @shipilev

[amosshi]

/integrate

[openjdk]

@amosshi Only the author (@shipilev) is allowed to issue the integrate command.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit a582e11.
Since your change was applied there have been 19 commits pushed to the master branch:

• b183cd2: 8314552: Fix javadoc tests to work with jtreg 7
• 0ae93db: 8323717: Introduce test keyword for tests that need external dependencies
• 61164ce: 8305962: update jcstress to 0.16
• f2565a6: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• 0e94be6: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
• 2dee6fb: 8294156: Allow PassFailJFrame.Builder to create test UI
• c681c5a: 8316053: Open some swing tests 3
• e5cc20c: 8315726: Open source several AWT applet tests
• fe840ca: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
• 5045b54: 8214400: Update hotspot application/jcstress jtreg tests wrappers to use jcstress 0.5
• ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/8dc28922c2c3cec9f8b9e9ee623dbd37df748b98...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit a582e11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.