-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8314552: Fix javadoc tests to work with jtreg 7 #2557
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@lutkerd, @gnu-andrew, @phohensee might want to take a look at this one. |
|
/approval request This is a variant of the fix for JDK 11u, required for jtreg upgrade. Reapplied hunks by hand, langtools tests pass with new jtreg. See 11u-dev PR for more details. Test-only change, risk is low. |
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit b183cd2.
Your commit was automatically rebased without conflicts. |
This is a variant of the fix for JDK 11u, required for jtreg upgrade.
Additional testing:
langtools:all
passes with jtreg-7.3.1+1 (some known failures fixed by other PRs)Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2557/head:pull/2557
$ git checkout pull/2557
Update a local copy of the PR:
$ git checkout pull/2557
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2557/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2557
View PR using the GUI difftool:
$ git pr show -t 2557
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2557.diff
Webrev
Link to Webrev Comment