Skip to content

8207855: Make applications/jcstress invoke tests in batches #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 26, 2024

Clean backport to enable future test maintenance backports. We cannot run this suite easily in OpenJDK, so we rely on backport cleanliness here.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8207855 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8207855: Make applications/jcstress invoke tests in batches (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2559/head:pull/2559
$ git checkout pull/2559

Update a local copy of the PR:
$ git checkout pull/2559
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2559

View PR using the GUI difftool:
$ git pr show -t 2559

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2559.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 480547304971b77150852ef8949381529ff33a54 8207855: Make applications/jcstress invoke tests in batches Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 26, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 26, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to enable future test maintenance backports. We cannot run this suite easily in OpenJDK, so we rely on backport cleanliness here. Test-only fix, risk is low.

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@shipilev
8207855: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8207855: Make applications/jcstress invoke tests in batches

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • a855cab: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
  • a60a5c4: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • 93c5f7c: 8326503: [11u] java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fail because of package org.junit.jupiter.api does not exist

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 27, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 27, 2024

Going to push as commit 10f0884.
Since your change was applied there have been 3 commits pushed to the master branch:

  • a855cab: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
  • a60a5c4: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • 93c5f7c: 8326503: [11u] java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fail because of package org.junit.jupiter.api does not exist

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 27, 2024
@openjdk openjdk bot closed this Feb 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 27, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@shipilev Pushed as commit 10f0884.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant