Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233790: Forward output from heap dumper to jcmd/jmap #256

Conversation

buddyliao
Copy link
Contributor

@buddyliao buddyliao commented Aug 19, 2021

Backport of the heap dump enhancement: Forward output from heap dumper to jcmd/jmap

Patch did not apply cleanly, I had to resolve/modify
src/hotspot/share/services/diagnosticCommand.cpp
src/hotspot/share/services/heapDumper.cpp
src/hotspot/share/services/heapDumper.hpp

since patch 7cbb67a is backport before this one, so this patch can't backport cleanly


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8233790: Forward output from heap dumper to jcmd/jmap

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/256/head:pull/256
$ git checkout pull/256

Update a local copy of the PR:
$ git checkout pull/256
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 256

View PR using the GUI difftool:
$ git pr show -t 256

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/256.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2021

👋 Welcome back buddyliao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b2a967382980bbaca2c2f7d08eab565024ede40e 8233790: Forward output from heap dumper to jcmd/jmap Aug 19, 2021
@openjdk
Copy link

openjdk bot commented Aug 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 19, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 19, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 19, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 19, 2021

⚠️ @buddyliao the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-b2a967382980bbaca2c2f7d08eab565024ede40e
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Aug 19, 2021

@buddyliao This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233790: Forward output from heap dumper to jcmd/jmap

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 90d5293: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 8f402b2: 8272628: Problemlist gc/stress/gcbasher/TestGCBasherWithCMS.java for x86_32
  • 0621d9d: 8226602: Test convenience reactive primitives from java.net.http with RS TCK
  • 6722cee: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 19, 2021
@linzang
Copy link
Contributor

linzang commented Aug 20, 2021

I have helped to add "jdk11u-fix-request" label at https://bugs.openjdk.java.net/browse/JDK-8233790.
Thanks!

@buddyliao
Copy link
Contributor Author

buddyliao commented Aug 20, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@buddyliao
Your change (at version 9bd0843) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

phohensee commented Aug 20, 2021

I'll push as soon as I get Maintainer approval.

@buddyliao
Copy link
Contributor Author

buddyliao commented Aug 24, 2021

Would anyone else could help me to do this review? Thank you

@RealCLanger
Copy link
Contributor

RealCLanger commented Aug 25, 2021

As Paul didn't react so far, I can sponsor this.
/sponsor

@openjdk
Copy link

openjdk bot commented Aug 25, 2021

Going to push as commit 5d1b9bb.
Since your change was applied there have been 37 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 25, 2021
@openjdk
Copy link

openjdk bot commented Aug 25, 2021

@RealCLanger @buddyliao Pushed as commit 5d1b9bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee
Copy link
Member

phohensee commented Aug 25, 2021

Thanks, Christoph.

@buddyliao buddyliao deleted the backport-b2a967382980bbaca2c2f7d08eab565024ede40e branch Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
4 participants