8323717: Introduce test keyword for tests that need external dependencies

[shipilev]

Semi-clean backport to allow running all tests cleanly. There was a contextual conflict in TEST.ROOT due to the absence of many keyword clean up patches, which I think can be backported and resolved later.

Additional testing:

• applications/jcstress applications/scimark are now properly skipped with JTREG_KEYWORDS=\!external-dep

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8323717 needs maintainer approval

Issue

• JDK-8323717: Introduce test keyword for tests that need external dependencies (Enhancement - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2569/head:pull/2569
$ git checkout pull/2569

Update a local copy of the PR:
$ git checkout pull/2569
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2569

View PR using the GUI difftool:
$ git pr show -t 2569

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2569.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (9516d204)

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Clean backport to make sure we can exclude JIB-managed tests from all test runs. Makes all test group much more usable for ad-hoc runs. Applies with contextual differences, see 11u-dev PR. Previously failing tests are now passing with !external-dep keyword supplied.

[openjdk]

@shipilev
8323717: The approval request has been created successfully.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8323717: Introduce test keyword for tests that need external dependencies

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

Going to push as commit 0ae93db.

[openjdk]

@shipilev Pushed as commit 0ae93db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.