Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM #2576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Feb 29, 2024

Backport of JDK-8266242

  • src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsDevice.m - clean backport
  • test/jdk/ProblemList.txt - this file has been ignored because the line does not exist

Testing

  • Local: Test failed
    • CheckDisplayModes.java:
MacBook Pro
16-inch, 2021
Chip Apple M1 Max
Memory: 32 GB
MacOS: 14.3.1 (23D60)
  • Pipeline:
  • Testing Machine:

Progress

  • Change must not contain extraneous whitespace
  • JDK-8266242 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2576/head:pull/2576
$ git checkout pull/2576

Update a local copy of the PR:
$ git checkout pull/2576
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2576

View PR using the GUI difftool:
$ git pr show -t 2576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2576.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 29, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f7d6d7a04faa704155ee8df33e7d344bb962566f 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 29, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 29, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@amosshi amosshi closed this Apr 9, 2024
@amosshi amosshi deleted the backport-8266242 branch April 9, 2024 21:55
@TheRealMDoerr
Copy link
Contributor

TheRealMDoerr commented Jun 3, 2024

This backport looks good and is clean when comparing to the 17u version. Unfortunately, the test still fails with "Invalid display mode" when this patch is applied. The test works in 17u after the fix. So, we will probably need other backports or 11u fixes for this to work. Postponing this backport (not in 11.0.24). It probably still makes sense to integrate it as it does no harm.

@amosshi amosshi restored the backport-8266242 branch June 4, 2024 06:57
@amosshi amosshi reopened this Jun 4, 2024
@amosshi amosshi changed the title 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM Backport 4ba565cbc76ed267a5abf9b68d2b9d62cf3fd2b9 Jun 4, 2024
@openjdk openjdk bot changed the title Backport 4ba565cbc76ed267a5abf9b68d2b9d62cf3fd2b9 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM Jun 4, 2024
@openjdk
Copy link

openjdk bot commented Jun 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the clean label Jun 4, 2024
@openjdk
Copy link

openjdk bot commented Jun 4, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
2 participants