Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310380: Handle problems in core-related tests on macOS when codesign tool does not work #2577

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Feb 29, 2024

Backport 8310380
add backports for JDK-8270199, JDK-8248194, JDK-8248667


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8310380 needs maintainer approval

Issue

  • JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2577/head:pull/2577
$ git checkout pull/2577

Update a local copy of the PR:
$ git checkout pull/2577
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2577/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2577

View PR using the GUI difftool:
$ git pr show -t 2577

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2577.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 29, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 39c104df44f17c1d65e35becd4272f73e2c6610c 8310380: Handle problems in core-related tests on macOS when codesign tool does not work Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 29, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 29, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@luchenlin luchenlin closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant