-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used #2578
Conversation
👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@snazarkin you need a review before requesting approval |
|
@snazarkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 65 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 2e46aad.
Your commit was automatically rebased without conflicts. |
@snazarkin Pushed as commit 2e46aad. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I'd like to backport this changes as it fixes some custom launchers issue. The backport is not clean:
The functionality was tested with simple
Without the patch it show the error
jdk_tier2 is OK as well
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2578/head:pull/2578
$ git checkout pull/2578
Update a local copy of the PR:
$ git checkout pull/2578
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2578/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2578
View PR using the GUI difftool:
$ git pr show -t 2578
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2578.diff
Webrev
Link to Webrev Comment