Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used #2578

Closed
wants to merge 3 commits into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented Feb 29, 2024

I'd like to backport this changes as it fixes some custom launchers issue. The backport is not clean:

  1. 8234821 was not backported to jdk11, so java_md_common.c need manual adjusting.
  2. The test can't be started as it depends on whole jpackage test pack. So I've removed it.

The functionality was tested with simple

cd ~/tools/bin
cp -r ~/jdk .
cp jdk/bin/java jdk/lib
jdk/lib/java -version

Without the patch it show the error

       Error: could not find libjava.so
       Error: Could not find Java SE Runtime Environment.

jdk_tier2 is OK as well


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8268974 needs maintainer approval

Issue

  • JDK-8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2578/head:pull/2578
$ git checkout pull/2578

Update a local copy of the PR:
$ git checkout pull/2578
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2578/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2578

View PR using the GUI difftool:
$ git pr show -t 2578

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2578.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 29, 2024

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 984003d5c969443abae2d889e92cba30da26e55f 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 29, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 29, 2024

Webrevs

@openjdk openjdk bot added the approval label Feb 29, 2024
@GoeLin
Copy link
Member

GoeLin commented Mar 7, 2024

@snazarkin you need a review before requesting approval

@openjdk openjdk bot removed the approval label Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

⚠️ @snazarkin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 4, 2024
@snazarkin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

Going to push as commit 2e46aad.
Since your change was applied there have been 68 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2024
@openjdk openjdk bot closed this Apr 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@snazarkin Pushed as commit 2e46aad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants