Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop #2581

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Mar 4, 2024

I backport this for parity with 11.0.24-oracle.
No code change, only code line change in src/hotspot/share/opto/loopopts.cpp, so make it clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326638 needs maintainer approval

Issue

  • JDK-8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2581/head:pull/2581
$ git checkout pull/2581

Update a local copy of the PR:
$ git checkout pull/2581
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2581/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2581

View PR using the GUI difftool:
$ git pr show -t 2581

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2581.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 4, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2024

Webrevs

@luchenlin
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@luchenlin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 6c0a88d: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
  • 2a78f2f: Merge
  • 5c5687d: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • a4a5c7f: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
  • a582e11: 8281507: Two javac tests have bad jtreg @clean tags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 7, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

Going to push as commit bc14b9f.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 4ef8db8: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • 6c0a88d: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
  • 2a78f2f: Merge
  • 5c5687d: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • a4a5c7f: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
  • a582e11: 8281507: Two javac tests have bad jtreg @clean tags

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2024
@openjdk openjdk bot closed this Mar 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@luchenlin Pushed as commit bc14b9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant