-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8256660: Disable DTLS 1.0 #2584
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Seems there are quite a lot of tests at test/jdk where 'jdk.tls.disabledAlgorithms' is set to a small number of disabled algorithms . Those settings were probably fine a long time ago, but for some of them it might make sense to review, if it would make sense to add more disabled algs that were add in the meantime . |
/integrate |
Going to push as commit b39a4d2.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.24-oracle.
Trivial resolve in java.security
Update:
Two test were failing with this change: javax/net/ssl/DTLS/InvalidRecords.java and javax/net/ssl/DTLS/NoMacInitialClientHello.java. Thanks to Sean Mullan who pointed me to the fix, see also
https://bugs.openjdk.org/browse/JDK-8326020
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2584/head:pull/2584
$ git checkout pull/2584
Update a local copy of the PR:
$ git checkout pull/2584
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2584/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2584
View PR using the GUI difftool:
$ git pr show -t 2584
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2584.diff
Webrev
Link to Webrev Comment