Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256660: Disable DTLS 1.0 #2584

Closed
wants to merge 5 commits into from
Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 7, 2024

I backport this for parity with 11.0.24-oracle.

Trivial resolve in java.security

Update:
Two test were failing with this change: javax/net/ssl/DTLS/InvalidRecords.java and javax/net/ssl/DTLS/NoMacInitialClientHello.java. Thanks to Sean Mullan who pointed me to the fix, see also
https://bugs.openjdk.org/browse/JDK-8326020


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8256660 needs maintainer approval
  • Change requires CSR request JDK-8280507 to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2584/head:pull/2584
$ git checkout pull/2584

Update a local copy of the PR:
$ git checkout pull/2584
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2584

View PR using the GUI difftool:
$ git pr show -t 2584

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2584.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 16744b34498e7aac59caef8c9b1a3d4d15f8c22e 8256660: Disable DTLS 1.0 Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 7, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256660: Disable DTLS 1.0

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 06cca19: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • f9a672a: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
  • 8e6a71d: 8299858: [Metrics] Swap memory limit reported incorrectly when too large
  • 4941b84: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • 4daa077: 8315834: Open source several Swing JSpinner related tests
  • 7d0de46: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • dd927ed: 8305645: System Tray icons get corrupted when Windows primary monitor changes
  • 21f04a2: 8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@MBaesken
Copy link
Member

Seems there are quite a lot of tests at test/jdk where 'jdk.tls.disabledAlgorithms' is set to a small number of disabled algorithms . Those settings were probably fine a long time ago, but for some of them it might make sense to review, if it would make sense to add more disabled algs that were add in the meantime .
But this is of course out of scope of this backport .

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 15, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 16, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 16, 2024

Going to push as commit b39a4d2.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 06cca19: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • f9a672a: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
  • 8e6a71d: 8299858: [Metrics] Swap memory limit reported incorrectly when too large
  • 4941b84: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • 4daa077: 8315834: Open source several Swing JSpinner related tests
  • 7d0de46: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • dd927ed: 8305645: System Tray icons get corrupted when Windows primary monitor changes
  • 21f04a2: 8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 16, 2024
@openjdk openjdk bot closed this Apr 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2024
@openjdk
Copy link

openjdk bot commented Apr 16, 2024

@GoeLin Pushed as commit b39a4d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8256660 branch April 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants