8219901: Noto fonts for East Asian countries cannot belong to CompositeFont #2586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This pull request contains a backport of commit 189e938d from the openjdk/jdk repository.
The commit being backported was authored by Toshio Nakamura on 2 Jun 2019 and was reviewed by Phil Race and Jayathirth D V.
Testing: original issue test case passes, all tests in
test/jdk/java/awt/font/
pass and tier 1 with GHA.Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2586/head:pull/2586
$ git checkout pull/2586
Update a local copy of the PR:
$ git checkout pull/2586
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2586/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2586
View PR using the GUI difftool:
$ git pr show -t 2586
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2586.diff
Webrev
Link to Webrev Comment