Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8219901: Noto fonts for East Asian countries cannot belong to CompositeFont #2586

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Mar 7, 2024

Hi all,

This pull request contains a backport of commit 189e938d from the openjdk/jdk repository.

The commit being backported was authored by Toshio Nakamura on 2 Jun 2019 and was reviewed by Phil Race and Jayathirth D V.

Testing: original issue test case passes, all tests in test/jdk/java/awt/font/ pass and tier 1 with GHA.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8219901 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8219901: Noto fonts for East Asian countries cannot belong to CompositeFont (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2586/head:pull/2586
$ git checkout pull/2586

Update a local copy of the PR:
$ git checkout pull/2586
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2586/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2586

View PR using the GUI difftool:
$ git pr show -t 2586

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2586.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 189e938d3ab6984581c83a5996281ec436e0ac2e 8219901: Noto fonts for East Asian countries cannot belong to CompositeFont Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

This backport pull request has now been updated with issue from the original commit.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review March 8, 2024 15:48
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Mar 8, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2024

Webrevs

@SoniaZaldana
Copy link
Member Author

Closing, as I missed regression introduced in JDK-8264703.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant