Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys #2587

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Mar 8, 2024

Backport of JDK-8218917

Testing

  • Local: Test passed
    • AltGraphModifierTest.java: Test results: no tests selected
    • AltKeyBug.java: Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-03-13,14,15

Progress

  • Change must not contain extraneous whitespace
  • JDK-8218917 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2587/head:pull/2587
$ git checkout pull/2587

Update a local copy of the PR:
$ git checkout pull/2587
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2587

View PR using the GUI difftool:
$ git pr show -t 2587

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2587.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2044245c90810075fbead432ad92de8fcb8af68a 8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • cb1b9a6: 8292717: Clean up checking of testing requirements in configure
  • 7ed3c3e: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch
  • d1bdb25: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
  • 2921ad6: 8321489: Update LCMS to 2.16
  • 0f09d0b: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
  • 1d102e8: 8248667: Need support for building native libraries located in the test/lib directory
  • 7de6f3f: 8314283: Support for NSS tests on aarch64 platforms
  • a097faa: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 1b3c570: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
  • 5cf250f: 8292716: Configure should check that jtreg is of the required version
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/f3069d13d23301405b096db6d4843500a5f5fa56...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@amosshi
Copy link
Contributor Author

amosshi commented Mar 15, 2024

/approval request "Backporting for parity with 11.0.24-oracle. Clean backport. SAP nightlies passed on 2024-03-13,14,15”

@openjdk
Copy link

openjdk bot commented Mar 15, 2024

@amosshi
8218917: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 15, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Apr 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 9, 2024

Going to push as commit 21f04a2.
Since your change was applied there have been 58 commits pushed to the master branch:

  • aa16bfe: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
  • 2e46aad: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used
  • eca3696: 8310923: Refactor Currency tests to use JUnit
  • 2f285fd: 8323994: gtest runner repeats test name for every single gtest assertion
  • 9ac4063: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • 6808c5c: 8320005: Allow loading of shared objects with .a extension on AIX
  • 910eb0e: 8306714: Open source few Swing event and AbstractAction tests
  • 1bbf93c: 8305943: Open source few AWT Focus related tests
  • 8e46e37: 8305942: Open source several AWT Focus related tests
  • fa8f02e: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests
  • ... and 48 more: https://git.openjdk.org/jdk11u-dev/compare/f3069d13d23301405b096db6d4843500a5f5fa56...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 9, 2024
@openjdk openjdk bot closed this Apr 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 9, 2024
@openjdk
Copy link

openjdk bot commented Apr 9, 2024

@amosshi Pushed as commit 21f04a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8218917 branch April 9, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant