Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248194: Need better support for running SA tests on core files #2591

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Mar 11, 2024

Backport for JDK-8248194, depends on JDK-8248667
test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java
There is only one test, so add the other core file test for the backport.

test/lib/jdk/test/lib/SA/SATestUtils.java
the 'unzipCores' is not exist, no need to remove.
test/lib/jdk/test/lib/apps/libLingeredApp.c
has already been updated by
#2590

Others clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8248194 needs maintainer approval

Issue

  • JDK-8248194: Need better support for running SA tests on core files (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2591/head:pull/2591
$ git checkout pull/2591

Update a local copy of the PR:
$ git checkout pull/2591
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2591

View PR using the GUI difftool:
$ git pr show -t 2591

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2591.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport db2d4e8f5af1274d82242d3d86b922656954e1ef 8248194: Need better support for running SA tests on core files Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 11, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248194: Need better support for running SA tests on core files

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • cb1b9a6: 8292717: Clean up checking of testing requirements in configure
  • 7ed3c3e: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch
  • d1bdb25: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
  • 2921ad6: 8321489: Update LCMS to 2.16
  • 0f09d0b: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Mar 15, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 18, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2024

Going to push as commit 6bcb8ac.
Since your change was applied there have been 11 commits pushed to the master branch:

  • a46d444: Merge
  • bd29eb6: 8327391: Add SipHash attribution file
  • 44825a0: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • ac9d090: 8015739: Background of JInternalFrame is located out of JInternalFrame
  • c5ba4b5: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 7482298: 8325326: [PPC64] Don't relocate in case of allocation failure
  • cb1b9a6: 8292717: Clean up checking of testing requirements in configure
  • 7ed3c3e: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch
  • d1bdb25: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
  • 2921ad6: 8321489: Update LCMS to 2.16
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/1d102e8f8afab928195550534110213ee31ace2e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2024
@openjdk openjdk bot closed this Mar 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2024
@openjdk
Copy link

openjdk bot commented Mar 21, 2024

@luchenlin Pushed as commit 6bcb8ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants