Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314283: Support for NSS tests on aarch64 platforms #2594

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Mar 11, 2024

I backport this for parity with 11.0.24-oracle.
test/jdk/sun/security/pkcs11/PKCS11Test.java
Clean except some added code lines are different.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8314283 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8314283: Support for NSS tests on aarch64 platforms (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2594/head:pull/2594
$ git checkout pull/2594

Update a local copy of the PR:
$ git checkout pull/2594
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2594

View PR using the GUI difftool:
$ git pr show -t 2594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2594.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 8314283: Support for NSS tests on aarch64 platforms Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 11, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2024

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8314283: Support for NSS tests on aarch64 platforms

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • a097faa: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 1b3c570: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
  • 5cf250f: 8292716: Configure should check that jtreg is of the required version
  • 069fbd7: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 21b88db: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • 84ff9b3: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • 29f300e: 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id
  • c8ca55b: 8314220: Configurable InlineCacheBuffer size
  • e6cec8f: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • eb5ef84: 8315677: Open source few swing JFileChooser and other tests
  • ... and 15 more: https://git.openjdk.org/jdk11u-dev/compare/b183cd239933552e1af8c890628b0bdee6ba21e7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 13, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

Going to push as commit 7de6f3f.
Since your change was applied there have been 25 commits pushed to the master branch:

  • a097faa: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 1b3c570: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
  • 5cf250f: 8292716: Configure should check that jtreg is of the required version
  • 069fbd7: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 21b88db: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • 84ff9b3: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • 29f300e: 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id
  • c8ca55b: 8314220: Configurable InlineCacheBuffer size
  • e6cec8f: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • eb5ef84: 8315677: Open source few swing JFileChooser and other tests
  • ... and 15 more: https://git.openjdk.org/jdk11u-dev/compare/b183cd239933552e1af8c890628b0bdee6ba21e7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2024
@openjdk openjdk bot closed this Mar 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@luchenlin Pushed as commit 7de6f3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants