Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg #2599

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Mar 12, 2024

I backport this for parity with 11.0.24-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324238 needs maintainer approval

Issue

  • JDK-8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2599/head:pull/2599
$ git checkout pull/2599

Update a local copy of the PR:
$ git checkout pull/2599
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2599/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2599

View PR using the GUI difftool:
$ git pr show -t 2599

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2599.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 62c9530c056dbaaf65be0f43295af3d225326a4c 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 12, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 1d102e8: 8248667: Need support for building native libraries located in the test/lib directory
  • 7de6f3f: 8314283: Support for NSS tests on aarch64 platforms
  • a097faa: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 1b3c570: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
  • 5cf250f: 8292716: Configure should check that jtreg is of the required version

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 14, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

Going to push as commit 0f09d0b.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 1d102e8: 8248667: Need support for building native libraries located in the test/lib directory
  • 7de6f3f: 8314283: Support for NSS tests on aarch64 platforms
  • a097faa: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 1b3c570: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
  • 5cf250f: 8292716: Configure should check that jtreg is of the required version

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2024
@openjdk openjdk bot closed this Mar 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2024
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@luchenlin Pushed as commit 0f09d0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant