-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292717: Clean up checking of testing requirements in configure #2600
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
feb0118
to
2b85a35
Compare
This backport pull request has now been updated with issue from the original commit. |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
Hi @shipilev, I figured it works smoothest if I backport in the order they arrived in 17. Best, Goetz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, thanks. It is generally hard to check that we have not introduced bugs while doing these move, but as long as they are mostly mechanical, I think we are safer.
I don't see the JTREG_MINIMUM_VERSION=6.1
hunk in the original commit (openjdk/jdk@16593cf), but I guess we need to move it from toolchain.m4
for 11u-dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good. Feel free to add the empty line.
|
GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap |
/integrate |
Going to push as commit cb1b9a6.
Your commit was automatically rebased without conflicts. |
I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17.
configure.ac::
I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not
supported by 11.
jdk-options.m4, toolchanin.m4
Deleted function has different body, deleted by hand.
lib-tests.m4: Copyright.
The original change moves and renames three
functions to lib-tests.m4. It does not change
the implementation of these.
So I modified the added code in lib-tests.m4
to have the unchanged function bodies that
were deleted in the other files.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2600/head:pull/2600
$ git checkout pull/2600
Update a local copy of the PR:
$ git checkout pull/2600
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2600/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2600
View PR using the GUI difftool:
$ git pr show -t 2600
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2600.diff
Webrev
Link to Webrev Comment